From: Stephen Hemminger <stephen@networkplumber.org>
To: Dimon Zhao <dimon.zhao@nebula-matrix.com>
Cc: dev@dpdk.org, Kyo Liu <kyo.liu@nebula-matrix.com>,
Leon Yu <leon.yu@nebula-matrix.com>,
Sam Chen <sam.chen@nebula-matrix.com>
Subject: Re: [PATCH v1 1/1] net/nbl: add igb_uio support for NBL VF devices
Date: Wed, 11 Feb 2026 09:13:33 -0800 [thread overview]
Message-ID: <20260211091333.7392c3b9@phoenix.local> (raw)
In-Reply-To: <20260211024029.33810-2-dimon.zhao@nebula-matrix.com>
On Tue, 10 Feb 2026 18:40:29 -0800
Dimon Zhao <dimon.zhao@nebula-matrix.com> wrote:
> Due to chip design limitations, only VF support
> the igb_uio driver. PF are not compatible.
>
> Signed-off-by: Dimon Zhao <dimon.zhao@nebula-matrix.com>
The patch makes sense, but I would like to see more before merging:
- more verbose commit message to help users and the next developer
works on this. It also should have proper grammar and be a complete sentence.
- update to the documentation files for this driver.
- add a release note if needed.
- does this fix a bug? does it need a Fixes tag.
next prev parent reply other threads:[~2026-02-11 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 2:40 [PATCH v1 0/1] support igb uio driver for VF devices Dimon Zhao
2026-02-11 2:40 ` [PATCH v1 1/1] net/nbl: add igb_uio support for NBL " Dimon Zhao
2026-02-11 17:13 ` Stephen Hemminger [this message]
2026-02-13 14:54 ` 回复：[PATCH " Dimon
2026-02-13 11:21 ` [PATCH v2 0/1] support igb uio driver for " Dimon Zhao
2026-02-13 11:21 ` [PATCH v2 1/1] net/nbl: add igb uio support for NBL " Dimon Zhao
2026-02-13 19:59 ` Stephen Hemminger
2026-02-25 3:39 ` [PATCH v3 0/1] support igb uio driver for " Dimon Zhao
2026-02-25 3:39 ` [PATCH v3 1/1] net/nbl: add igb uio support for NBL " Dimon Zhao
2026-02-25 16:50 ` Stephen Hemminger
2026-02-27 1:45 ` 回复：[PATCH " Dimon
2026-02-26 20:14 ` [PATCH " Stephen Hemminger
2026-02-27 2:57 ` [PATCH v4 0/1] NBL add probe checks for unsupported UIO drivers Dimon Zhao
2026-02-27 2:57 ` [PATCH v4 1/1] net/nbl: " Dimon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211091333.7392c3b9@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=dimon.zhao@nebula-matrix.com \
--cc=kyo.liu@nebula-matrix.com \
--cc=leon.yu@nebula-matrix.com \
--cc=sam.chen@nebula-matrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox