Re: [PATCH v4 28/35] net/intel: merge ring writes in simple Tx for ice and i40e

Medvedkin, Vladimir
2026-02-09T23:19:09Z

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

On 2/9/2026 4:45 PM, Bruce Richardson wrote:
> The ice and i40e drivers have identical code for writing ring entries in
> the simple Tx path, so merge in the descriptor writing code.
>
> Signed-off-by: Bruce Richardson<bruce.richardson@intel.com>
> ---
> drivers/net/intel/common/tx.h | 6 ++
> drivers/net/intel/common/tx_scalar.h | 60 ++++++++++++++
> drivers/net/intel/i40e/i40e_rxtx.c | 79 +------------------
> drivers/net/intel/i40e/i40e_rxtx.h | 3 -
> .../net/intel/i40e/i40e_rxtx_vec_altivec.c | 4 +-
> drivers/net/intel/i40e/i40e_rxtx_vec_avx2.c | 4 +-
> drivers/net/intel/i40e/i40e_rxtx_vec_avx512.c | 4 +-
> drivers/net/intel/i40e/i40e_rxtx_vec_neon.c | 4 +-
> drivers/net/intel/ice/ice_rxtx.c | 69 +---------------
> drivers/net/intel/ice/ice_rxtx.h | 2 -
> drivers/net/intel/ice/ice_rxtx_vec_avx2.c | 4 +-
> drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 4 +-
> 12 files changed, 86 insertions(+), 157 deletions(-)
>
> diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
> index 203938180b..ef6d543e7a 100644
> --- a/drivers/net/intel/common/tx.h
> +++ b/drivers/net/intel/common/tx.h
> @@ -63,6 +63,12 @@ enum ci_tx_l2tag1_field {
> /* Common maximum data per TX descriptor */
> #define CI_MAX_DATA_PER_TXD (CI_TXD_QW1_TX_BUF_SZ_M >> CI_TXD_QW1_TX_BUF_SZ_S)
>
> +/* Common TX maximum burst size for chunked transmission in simple paths */
> +#define CI_TX_MAX_BURST 32
eventually it would be good to replace all the rest {IXGBE, I40E, ICE,
IDPF_VPMD}_TX_MAX_BURST with this
<snip>
>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

--
Regards,
Vladimir

[-- Attachment #2: Type: text/html, Size: 2807 bytes --]