Re: [PATCH v4 29/35] net/intel: consolidate ice and i40e buffer free function

Medvedkin, Vladimir
2026-02-09T23:19:19Z

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On 2/9/2026 4:45 PM, Bruce Richardson wrote:
> The buffer freeing function for the simple scalar Tx path is almost
> identical in both ice and i40e drivers, except that the i40e has
> batching for the FAST_FREE case. Consolidate both functions into a
> common one based off the better i40e version.
>
> Signed-off-by: Bruce Richardson<bruce.richardson@intel.com>
> ---
> drivers/net/intel/common/tx.h | 3 ++
> drivers/net/intel/common/tx_scalar.h | 58 +++++++++++++++++++++++++
> drivers/net/intel/i40e/i40e_rxtx.c | 63 +---------------------------
> drivers/net/intel/ice/ice_rxtx.c | 45 +-------------------
> 4 files changed, 65 insertions(+), 104 deletions(-)
>
> diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
> index ef6d543e7a..67378a0803 100644
> --- a/drivers/net/intel/common/tx.h
> +++ b/drivers/net/intel/common/tx.h
> @@ -66,6 +66,9 @@ enum ci_tx_l2tag1_field {
> /* Common TX maximum burst size for chunked transmission in simple paths */
> #define CI_TX_MAX_BURST 32
>
> +/* Common TX maximum free buffer size for batched bulk freeing */
> +#define CI_TX_MAX_FREE_BUF_SZ 64
> +
same here, eventually it would be good to replace all the rest {IXGBE,
I40E, ICE, RTE_FM10K}_TX_MAX_FREE_BUF_SZ  with this
<snip>
>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

--
Regards,
Vladimir

[-- Attachment #2: Type: text/html, Size: 2449 bytes --]