Re: [REVIEW] doc/nfb: cleanup and update guide

Stephen Hemminger
2026-02-02T17:52:53Z

On Mon, 2 Feb 2026 09:42:35 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> ## Patch 3/8: net/nfb: add vdev as alternative device probe method
>
> ### Errors
> None.
>
> ### Warnings
>
> 1. **Unnecessary cast of void pointer** (nfb_vdev.c:62)
> ```c
> ret = rte_kvargs_process(kvlist, NFB_ARG_PORT,
> nfb_eth_dev_create_for_ifc_by_port, (void *)&ifc_params);
> ```
> The cast `(void *)` is unnecessary in C.
>
> 2. **Missing newline at end of file** (nfb_vdev.c)
> - The file appears to end without a trailing newline after line 108.
>
> ### Info
> - Useful addition for virtual/simulated NFB devices.

The first is a "meh" not a serious issue

Not sure why false positive #2 happens.