public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Howard Wang <howard_wang@realsil.com.cn>
To: <dev@dpdk.org>
Cc: <pro_nic_dpdk@realtek.com>,
	Howard Wang <howard_wang@realsil.com.cn>, <stable@dpdk.org>
Subject: [PATCH v4 01/13] net/r8169: fix crash in RTL8168FP init
Date: Fri, 13 Feb 2026 11:20:06 +0800	[thread overview]
Message-ID: <20260213032018.175753-2-howard_wang@realsil.com.cn> (raw)
In-Reply-To: <20260213032018.175753-1-howard_wang@realsil.com.cn>

The rtl8168fp_ops structure was missing the hw_phy_mcu_config function
pointer, causing a NULL pointer dereference during device initialization
when the driver attempts to configure the PHY microcontroller.

Add hw_phy_mcu_config_8168fp() as a no-op function since the RTL8168FP
does not require PHY MCU configuration. This matches the pattern used
by other chip variants that don't need PHY MCU updates.

Fixes: d9ee71b5f1bc ("net/r8169: support RTL8168 series")
Cc: stable@dpdk.org

Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
---
 drivers/net/r8169/base/rtl8168fp.c     | 1 +
 drivers/net/r8169/base/rtl8168fp.h     | 1 +
 drivers/net/r8169/base/rtl8168fp_mcu.c | 6 ++++++
 3 files changed, 8 insertions(+)

diff --git a/drivers/net/r8169/base/rtl8168fp.c b/drivers/net/r8169/base/rtl8168fp.c
index b8a058bbd9..9aa3cabeb8 100644
--- a/drivers/net/r8169/base/rtl8168fp.c
+++ b/drivers/net/r8169/base/rtl8168fp.c
@@ -192,4 +192,5 @@ const struct rtl_hw_ops rtl8168fp_ops = {
 	.hw_ephy_config    = hw_ephy_config_8168fp,
 	.hw_phy_config     = hw_phy_config_8168fp,
 	.hw_mac_mcu_config = hw_mac_mcu_config_8168fp,
+	.hw_phy_mcu_config = hw_phy_mcu_config_8168fp,
 };
diff --git a/drivers/net/r8169/base/rtl8168fp.h b/drivers/net/r8169/base/rtl8168fp.h
index 4613fe9a98..194f14af4e 100644
--- a/drivers/net/r8169/base/rtl8168fp.h
+++ b/drivers/net/r8169/base/rtl8168fp.h
@@ -10,5 +10,6 @@
 extern const struct rtl_hw_ops rtl8168fp_ops;
 
 void hw_mac_mcu_config_8168fp(struct rtl_hw *hw);
+void hw_phy_mcu_config_8168fp(struct rtl_hw *hw __rte_unused);
 
 #endif
diff --git a/drivers/net/r8169/base/rtl8168fp_mcu.c b/drivers/net/r8169/base/rtl8168fp_mcu.c
index 839dcfde61..7757e5f448 100644
--- a/drivers/net/r8169/base/rtl8168fp_mcu.c
+++ b/drivers/net/r8169/base/rtl8168fp_mcu.c
@@ -268,3 +268,9 @@ hw_mac_mcu_config_8168fp(struct rtl_hw *hw)
 		break;
 	}
 }
+
+void
+hw_phy_mcu_config_8168fp(struct rtl_hw *hw __rte_unused)
+{
+	/* Do nothing */
+}
-- 
2.34.1


  reply	other threads:[~2026-02-13  3:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  3:20 [PATCH v4 00/13] net/r8169: driver updates and new hardware support Howard Wang
2026-02-13  3:20 ` Howard Wang [this message]
2026-02-13  3:20 ` [PATCH v4 02/13] net/r8169: optimize Rx descriptor fetch number Howard Wang
2026-02-13  3:20 ` [PATCH v4 03/13] net/r8169: add support for RTL8168KD Howard Wang
2026-02-13  3:20 ` [PATCH v4 04/13] net/r8169: update hardware configurations for 8127 Howard Wang
2026-02-13  3:20 ` [PATCH v4 05/13] net/r8169: adjust jumbo frame size limit for non-1G cards Howard Wang
2026-02-13  3:20 ` [PATCH v4 06/13] net/r8169: remove support for CFG_METHOD_69 Howard Wang
2026-02-13  3:20 ` [PATCH v4 07/13] net/r8169: update hardware configurations for 8126 Howard Wang
2026-02-13  3:20 ` [PATCH v4 08/13] net/r8169: update hardware configurations for 8125 Howard Wang
2026-02-13  3:20 ` [PATCH v4 09/13] net/r8169: add support for RTL9151 Howard Wang
2026-02-13  3:20 ` [PATCH v4 10/13] net/r8169: add support for RTL8125K Howard Wang
2026-02-13  3:20 ` [PATCH v4 11/13] net/r8169: fix one bug about RTL8168KB Howard Wang
2026-02-13  3:20 ` [PATCH v4 12/13] net/r8169: ensure the old mapping is used Howard Wang
2026-02-13  3:20 ` [PATCH v4 13/13] net/r8169: fix bitmask logic for RTL8127 Howard Wang
2026-02-13 16:53 ` [PATCH v4 00/13] net/r8169: driver updates and new hardware support Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260213032018.175753-2-howard_wang@realsil.com.cn \
    --to=howard_wang@realsil.com.cn \
    --cc=dev@dpdk.org \
    --cc=pro_nic_dpdk@realtek.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox