From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Selwin Sebastian <selwin.sebastian@amd.com>,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Jeroen de Borst <jeroendb@google.com>,
Joshua Washington <joshwash@google.com>,
Rosen Xu <rosen.xu@altera.com>
Subject: Re: [PATCH] drivers: disable comma warnings selectively
Date: Fri, 13 Feb 2026 09:25:17 -0800 [thread overview]
Message-ID: <20260213092517.4bb136af@phoenix.local> (raw)
In-Reply-To: <20260213151559.656837-1-bruce.richardson@intel.com>
On Fri, 13 Feb 2026 15:14:00 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> Rather than disabling -Wcomma for all drivers, only disable it on a
> case-by-case basis for drivers that need it disabled. Use a variable to
> do so, to avoid issues with compilers like MSVC that don't support the
> -Wno-comma flag.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Some of those drivers should be easy to fix?
This change would be helped by fixing and introducing FOREACH_SAFE macros.
I started that but it never got anywhere
next prev parent reply other threads:[~2026-02-13 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:14 [PATCH] drivers: disable comma warnings selectively Bruce Richardson
2026-02-13 17:25 ` Stephen Hemminger [this message]
2026-02-13 17:35 ` Bruce Richardson
2026-02-13 18:47 ` Stephen Hemminger
2026-02-19 15:22 ` [PATCH v2] " Bruce Richardson
2026-02-19 21:53 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213092517.4bb136af@phoenix.local \
--to=stephen@networkplumber.org \
--cc=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=kishore.padmanabha@broadcom.com \
--cc=rosen.xu@altera.com \
--cc=selwin.sebastian@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox