Re: [PATCH dpdk v3 0/2] hash: safe data replacement on overwrite

Robin Jarry
2026-03-09T07:52:38Z

Konstantin Ananyev, Mar 09, 2026 at 08:50:
>> * Removed the rte_hash_replace_key_data() API
>
> That's a pity - I think it is a useful one.
>
>> which required to bubble
>> a potential old_data pointer from search_and_update() to all
>> intermediate callers down to __rte_hash_add_key_with_hash(). It made
>> an already complex code even more obscure.

I can send it back but it will make the code complex since I cannot free
the pointer in the callers. I need to pass it down the call chain to
make the free-or-return-old-data decision.

Let me know what you prefer.