Re: [PATCH v9 0/8] net/nfb: rework to real multiport

Stephen Hemminger
2026-02-16T22:11:11Z

On Mon, 16 Feb 2026 17:24:58 +0100
spinler@cesnet.cz wrote:

> From: Martin Spinler <spinler@cesnet.cz>
>
> This series implements real multiport for better user experience.
>
> The existing driver creates one ethdev/port for one PCI device.
> As the CESNET-NDK based cards aren't capable to represent each
> Ethernet port by own PCI device, new driver implementation
> processes real port configuration from firmware/card and switches
> from rte_eth_dev_pci_generic_probe to multiple rte_eth_dev_create calls.
>
> ---
> Depends-on: patch-37245 ("doc/nfb: update release notes for nfb driver")

After some feedback to the AI review. It still had minor feedback, do you want more detail?
I can take this as is or you can send new version.

NFB v9 Review Summary
8 patches, v9 — Martin Spinler's multi-port NFB driver rework. Overall a clean, well-structured series.

Warnings:

Patch 2: If rte_eth_dev_create() succeeds but rte_eth_dev_get_by_name()
returns NULL, the created device is never added to the cleanup TAILQ
and leaks.

Patch 3: nfb_default_dev_path() return value used without NULL check before passing to nfb_open().

Patch 4: The kvargs callback returns errors from input validation (e.g., bad port string) but ifc_params.ret is only set after nfb_eth_dev_create_for_ifc, so the caller can overwrite the real error with 0.

Patch 8: Release notes don't mention the new vdev/simulation support from patch 3.