From: Stephen Hemminger <stephen@networkplumber.org>
To: Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com>
Cc: <dev@dpdk.org>, <Selwin.Sebastian@amd.com>
Subject: Re: [PATCH 2/3] net/axgbe: Add support for Marvell M88E1512 PHY
Date: Mon, 16 Feb 2026 08:29:14 -0800 [thread overview]
Message-ID: <20260216082914.636d002e@phoenix.local> (raw)
In-Reply-To: <20260216125205.1032-2-ashokkumar.natarajan@amd.com>
On Mon, 16 Feb 2026 18:22:04 +0530
Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com> wrote:
> diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h
> index 12d77cd520..3a9dc81691 100644
> --- a/drivers/net/axgbe/axgbe_ethdev.h
> +++ b/drivers/net/axgbe/axgbe_ethdev.h
> @@ -276,6 +276,7 @@ struct axgbe_phy {
> int pause_autoneg;
> int tx_pause;
> int rx_pause;
> + int id;
> };
>
These really shouldn't be "int".
This looks like legacy era K&R code style.
The driver has this in lots of places.
The flags should be bool, but that is another issue.
next prev parent reply other threads:[~2026-02-16 16:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 12:52 [PATCH 1/3] net/axgbe: Add external PHY read/write functions Ashok Kumar Natarajan
2026-02-16 12:52 ` [PATCH 2/3] net/axgbe: Add support for Marvell M88E1512 PHY Ashok Kumar Natarajan
2026-02-16 16:29 ` Stephen Hemminger [this message]
2026-02-25 12:47 ` [PATCH v2 2/3] net/axgbe: add support for marvell m88e1512 PHY Ashok Kumar Natarajan
2026-02-26 16:47 ` [PATCH v3 " Ashok Kumar Natarajan
2026-02-27 8:44 ` [PATCH v4 " Ashok Kumar Natarajan
2026-02-27 23:25 ` Stephen Hemminger
2026-02-28 14:39 ` [PATCH v5 " Ashok Kumar Natarajan
2026-02-16 12:52 ` [PATCH 3/3] net/axgbe: Add support for 100Mbps link speed Ashok Kumar Natarajan
2026-02-25 12:49 ` [PATCH v2 3/3] net/axgbe: add " Ashok Kumar Natarajan
2026-02-26 16:49 ` [PATCH v3 3/3] net/axgbe: fix 100M SGMII mode Ashok Kumar Natarajan
2026-02-27 8:45 ` [PATCH v4 " Ashok Kumar Natarajan
2026-02-28 14:40 ` [PATCH v5 " Ashok Kumar Natarajan
2026-02-17 0:27 ` [PATCH 1/3] net/axgbe: Add external PHY read/write functions Stephen Hemminger
2026-02-25 12:44 ` [PATCH v2 1/3] net/axgbe: add " Ashok Kumar Natarajan
2026-02-25 23:09 ` Stephen Hemminger
2026-02-26 17:09 ` Natarajan, Ashok Kumar
2026-02-26 16:46 ` [PATCH v3 " Ashok Kumar Natarajan
2026-02-26 19:09 ` Stephen Hemminger
2026-02-27 8:43 ` [PATCH v4 " Ashok Kumar Natarajan
2026-02-28 14:37 ` [PATCH v5 " Ashok Kumar Natarajan
2026-02-28 16:41 ` Stephen Hemminger
2026-03-01 4:35 ` Natarajan, Ashok Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260216082914.636d002e@phoenix.local \
--to=stephen@networkplumber.org \
--cc=Selwin.Sebastian@amd.com \
--cc=ashokkumar.natarajan@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox