public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com>
Cc: <dev@dpdk.org>, <Selwin.Sebastian@amd.com>
Subject: Re: [PATCH] net/axgbe: added marvel m88e1512 PHY support
Date: Mon, 16 Feb 2026 14:12:52 -0800	[thread overview]
Message-ID: <20260216141252.76f2b567@phoenix.local> (raw)
In-Reply-To: <20260216085431.972-1-ashokkumar.natarajan@amd.com>

On Mon, 16 Feb 2026 14:24:31 +0530
Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com> wrote:

> Added marvel m88e1512 1G PHY support in amd axgbe driver
> 
> Signed-off-by: Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com>

Multiple CI build failures. Fix and resubmit.
FAILED: drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_phy_impl.c.o 
clang -Idrivers/libtmp_rte_net_axgbe.a.p -Idrivers -I../drivers -Idrivers/net/axgbe -I../drivers/net/axgbe -Ilib/ethdev -I../lib/ethdev -Ilib/eal/common -I../lib/eal/common -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -I../kernel/linux -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/argparse -I../lib/argparse -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h -Wvla -Wcast-qual -Wcomma -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wshadow -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wno-address-of-packed-member -Wno-comma -Wno-cast-qual -Wno-shadow -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.axgbe -DRTE_ANNOTATE_LOCKS -Wthread-safety -MD -MQ drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_phy_impl.c.o -MF drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_phy_impl.c.o.d -o drivers/libtmp_rte_net_axgbe.a.p/net_axgbe_axgbe_phy_impl.c.o -c ../drivers/net/axgbe/axgbe_phy_impl.c
../drivers/net/axgbe/axgbe_phy_impl.c:2359:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
 2359 |         if (bmcr == -1)
      |             ^~~~~~~~~~
../drivers/net/axgbe/axgbe_phy_impl.c:2368:9: note: uninitialized use occurs here
 2368 |         return ret;
      |                ^~~
../drivers/net/axgbe/axgbe_phy_impl.c:2359:2: note: remove the 'if' if its condition is always false
 2359 |         if (bmcr == -1)
      |         ^~~~~~~~~~~~~~~
 2360 |                 goto out;
      |                 ~~~~~~~~
../drivers/net/axgbe/axgbe_phy_impl.c:2356:9: note: initialize the variable 'ret' to silence this warning
 2356 |         int ret;
      |                ^
      |                 = 0

      reply	other threads:[~2026-02-16 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16  8:54 [PATCH] net/axgbe: added marvel m88e1512 PHY support Ashok Kumar Natarajan
2026-02-16 22:12 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260216141252.76f2b567@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=Selwin.Sebastian@amd.com \
    --cc=ashokkumar.natarajan@amd.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox