public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Congjie Zhou <zcjie0802@qq.com>,
	stable@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v6] eal/linux: fix fbarray name collision in containers
Date: Mon, 16 Feb 2026 14:26:21 -0800	[thread overview]
Message-ID: <20260216142621.2b9882f3@phoenix.local> (raw)
In-Reply-To: <CAJFAV8w2SEdV1QNshrrN1bEtQhD8KS7ajK+mH9Y4jDRemQp9qw@mail.gmail.com>

On Mon, 16 Feb 2026 18:22:48 +0100
David Marchand <david.marchand@redhat.com> wrote:

> On Fri, 13 Feb 2026 at 23:01, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > From: Congjie Zhou <zcjie0802@qq.com>
> >
> > When multiple secondary processes run in different containers that
> > share the same hugetlbfs mount, the fbarray names can collide.
> > This happens because containers use separate PID namespaces, so
> > different processes in different containers can have the same PID.
> >
> > Fix by replacing the PID with a timestamp-based value. The TSC
> > (timestamp counter) provides sufficient uniqueness since containers
> > starting at the same CPU cycle is practically impossible - even 1ms
> > of startup time difference means millions of cycles apart at GHz
> > frequencies.
> >
> > Also, reduce the name buffer from PATH_MAX to RTE_FBARRAY_NAME_LEN
> > since it is only used for the fbarray name.
> >  
> 
> Afaics, the filename generation comes from:
> 524e43c2ad9a ("mem: prepare memseg lists for multiprocess sync")
> 
> > Fixes: 046aa5c4477b ("mem: add memalloc init stage")  
> 
> This change ^^ only moved the point in EAL init where the name was generated.

Thanks, I didn't go digging back through the history and was more looking
at what to blame.

      reply	other threads:[~2026-02-16 22:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14  8:37 [PATCH] eal/linux: redefine the name for rte_fbarray_init() Congjie Zhou
2024-11-14 16:24 ` Stephen Hemminger
2024-11-14 17:06   ` Stephen Hemminger
2024-11-15  2:26     ` Zhou congjie
2024-11-15  5:32       ` Stephen Hemminger
2024-11-15  1:57   ` Zhou congjie
2024-11-15  2:00   ` Zhou congjie
2024-11-15  7:50 ` [PATCH v2] eal/linux: fix fbarray name with multiple secondary processes Congjie Zhou
2024-11-15 16:38   ` Stephen Hemminger
2024-11-15 20:09   ` Stephen Hemminger
2024-11-16  2:16     ` [PATCH v2] eal/linux: fix fbarray name with multiple secondaryprocesses Zhou congjie
2024-11-16  2:53     ` Zhou congjie
2024-11-16  4:07 ` [PATCH v3] eal/linux: fix fbarray name with multiple secondary processes Congjie Zhou
2026-01-14  5:25   ` Stephen Hemminger
2026-01-14  5:54   ` [PATCH v4] Subject: eal/linux: fix fbarray name collision in containers Stephen Hemminger
2026-02-13 21:50 ` [PATCH v5] " Stephen Hemminger
2026-02-13 22:00 ` [PATCH v6] " Stephen Hemminger
2026-02-16 17:22   ` David Marchand
2026-02-16 22:26     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260216142621.2b9882f3@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=zcjie0802@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox