Re: [PATCH 2/3] net/axgbe: Add support for Marvell M88E1512 PHY

Stephen Hemminger
2026-02-16T16:29:21Z

On Mon, 16 Feb 2026 18:22:04 +0530
Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com> wrote:

> diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h
> index 12d77cd520..3a9dc81691 100644
> --- a/drivers/net/axgbe/axgbe_ethdev.h
> +++ b/drivers/net/axgbe/axgbe_ethdev.h
> @@ -276,6 +276,7 @@ struct axgbe_phy {
> int pause_autoneg;
> int tx_pause;
> int rx_pause;
> + int id;
> };
>

These really shouldn't be "int".
This looks like legacy era K&R code style.

The driver has this in lots of places.

The flags should be bool, but that is another issue.