Re: [PATCH] eal/linux: fix HPET symbols export

David Marchand
2026-02-19T08:19:51Z

On Wed, 18 Feb 2026 at 11:19, David Marchand <david.marchand@redhat.com> wrote:
>
> The .map generation script has no clue about build configuration as it
> relies only on the presence of RTE_EXPORT* and RTE_VERSION* markers in
> a source file.
>
> As a consequence, Linux eal_exports.map contains references to
> HPET symbols regardless of the use_hpet meson option value.
>
> $ meson configure build -Duse_hpet=false
> $ ninja -C build
> ...
> $ grep hpet build/lib/eal_exports.map
> rte_eal_hpet_init;
> rte_get_hpet_cycles;
> rte_get_hpet_hz;
>
> As far as I have seen, superfluous exports have no impact on generating
> a shared library with the GNU linker, yet it might be different with
> other linkers (MSVC linker would complain, for example).
>
> Moving those symbols to a dedicated source file solves this (non?) issue.
>
> Fixes: 57c194d142d9 ("build: use dynamically generated version maps")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Recheck-request: iol-unit-amd64-testing

--
David Marchand