* [PATCH] net/nfb: fix eth_node memory leak in deinit
@ 2026-02-18 18:16 Stephen Hemminger
2026-02-19 6:17 ` Martin Spinler
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2026-02-18 18:16 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Martin Spinler
The eth_node array allocated with calloc() in nfb_nc_eth_init() is
freed on the error path but not in the normal teardown path via
nfb_nc_eth_deinit(). Add the missing free().
Fixes: 9b173c0f89 ("net/nfb: get correct link speed")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/nfb/nfb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index e267dca9af..ba7c849a4b 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -186,6 +186,7 @@ nfb_nc_eth_deinit(struct pmd_internals *intl)
for (i = 0; i < intl->max_rxmac; i++)
nc_rxmac_close(intl->rxmac[i]);
+ free(intl->eth_node);
free(intl->txmac);
free(intl->rxmac);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfb: fix eth_node memory leak in deinit
2026-02-18 18:16 [PATCH] net/nfb: fix eth_node memory leak in deinit Stephen Hemminger
@ 2026-02-19 6:17 ` Martin Spinler
0 siblings, 0 replies; 2+ messages in thread
From: Martin Spinler @ 2026-02-19 6:17 UTC (permalink / raw)
To: Stephen Hemminger, dev
Thank you. Can be squashed, but it's OK this way.
Acked-by: Martin Spinler <spinler@cesnet.cz>
On Wed, 2026-02-18 at 10:16 -0800, Stephen Hemminger wrote:
> The eth_node array allocated with calloc() in nfb_nc_eth_init() is
> freed on the error path but not in the normal teardown path via
> nfb_nc_eth_deinit(). Add the missing free().
>
> Fixes: 9b173c0f89 ("net/nfb: get correct link speed")
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/nfb/nfb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
> index e267dca9af..ba7c849a4b 100644
> --- a/drivers/net/nfb/nfb_ethdev.c
> +++ b/drivers/net/nfb/nfb_ethdev.c
> @@ -186,6 +186,7 @@ nfb_nc_eth_deinit(struct pmd_internals *intl)
> for (i = 0; i < intl->max_rxmac; i++)
> nc_rxmac_close(intl->rxmac[i]);
>
> + free(intl->eth_node);
> free(intl->txmac);
> free(intl->rxmac);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-19 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 18:16 [PATCH] net/nfb: fix eth_node memory leak in deinit Stephen Hemminger
2026-02-19 6:17 ` Martin Spinler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox