From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v3 03/10] net/tap: clarify TUN/TAP flag assignment
Date: Thu, 19 Feb 2026 21:02:05 -0800 [thread overview]
Message-ID: <20260220050409.1571022-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20260220050409.1571022-1-stephen@networkplumber.org>
Add parentheses in the ternary expression that relied on operator
precedence between '?:' and '|'. No functional change.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/tap/rte_eth_tap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index aa236cf967..e06e1ca079 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -155,7 +155,8 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent)
* to check if a received packet has been truncated.
*/
ifr.ifr_flags = (pmd->type == ETH_TUNTAP_TYPE_TAP) ?
- IFF_TAP : IFF_TUN | IFF_POINTOPOINT;
+ IFF_TAP : (IFF_TUN | IFF_POINTOPOINT);
+
strlcpy(ifr.ifr_name, pmd->name, IFNAMSIZ);
fd = open(TUN_TAP_DEV_PATH, O_RDWR);
--
2.51.0
next prev parent reply other threads:[~2026-02-20 5:04 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 19:52 [PATCH 00/10] net/tap: tests, cleanups, and error path fixes Stephen Hemminger
2026-02-15 19:52 ` [PATCH 01/10] test: add unit tests for TAP PMD Stephen Hemminger
2026-02-16 0:46 ` Stephen Hemminger
2026-02-15 19:52 ` [PATCH 02/10] net/tap: replace runtime speed capability with constant Stephen Hemminger
2026-02-15 19:52 ` [PATCH 03/10] net/tap: clarify TUN/TAP flag assignment Stephen Hemminger
2026-02-15 21:45 ` Morten Brørup
2026-02-16 0:47 ` Stephen Hemminger
2026-02-16 5:56 ` Morten Brørup
2026-02-15 19:52 ` [PATCH 04/10] net/tap: extend fixed MAC range to 16 bits Stephen Hemminger
2026-02-15 19:52 ` [PATCH 05/10] net/tap: skip checksum on truncated L4 headers Stephen Hemminger
2026-02-15 19:52 ` [PATCH 06/10] net/tap: fix resource leaks in tap create error path Stephen Hemminger
2026-02-15 19:52 ` [PATCH 07/10] net/tap: fix resource leaks in secondary process probe Stephen Hemminger
2026-02-15 19:52 ` [PATCH 08/10] net/tap: free IPC reply buffer on queue count mismatch Stephen Hemminger
2026-02-15 19:52 ` [PATCH 09/10] net/tap: fix use-after-free on remote flow creation failure Stephen Hemminger
2026-02-15 19:52 ` [PATCH 10/10] net/tap: free remote flow when implicit rule already exists Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 00/11] net/tap: test, cleanups and error path fixes Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 01/11] test: add unit tests for TAP PMD Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 02/11] net/tap: replace runtime speed capability with constant Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 03/11] net/tap: clarify TUN/TAP flag assignment Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 04/11] net/tap: extend fixed MAC range to 16 bits Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 05/11] net/tap: skip checksum on truncated L4 headers Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 06/11] net/tap: fix resource leaks in tap create error path Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 07/11] net/tap: fix resource leaks in secondary process probe Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 08/11] net/tap: free IPC reply buffer on queue count mismatch Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 09/11] net/tap: fix use-after-free on remote flow creation failure Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 10/11] net/tap: free remote flow when implicit rule already exists Stephen Hemminger
2026-02-16 23:02 ` [PATCH v2 11/11] net/tap: track device by ifindex instead of name Stephen Hemminger
2026-02-17 1:28 ` Stephen Hemminger
2026-02-17 15:04 ` [RFT 0/4] net/mlx5: fix several correctness bugs Stephen Hemminger
2026-02-17 15:04 ` [RFT 1/4] net/mlx5: fix NULL dereference in Tx queue start Stephen Hemminger
2026-02-26 9:55 ` Dariusz Sosnowski
2026-02-17 15:05 ` [RFT 2/4] net/mlx5: fix counter leak in hairpin queue setup Stephen Hemminger
2026-02-26 9:57 ` Dariusz Sosnowski
2026-02-17 15:05 ` [RFT 3/4] net/mlx5: fix use-after-free in ASO management init Stephen Hemminger
2026-02-26 9:57 ` Dariusz Sosnowski
2026-02-17 15:05 ` [RFT 4/4] net/mlx5: fix counter truncation in queue counter read Stephen Hemminger
2026-02-26 9:58 ` Dariusz Sosnowski
2026-03-01 10:33 ` [RFT 0/4] net/mlx5: fix several correctness bugs Raslan Darawsheh
2026-02-20 5:02 ` [PATCH v3 00/10] net/tap: bug fixes and add test Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 01/10] test: add unit tests for TAP PMD Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 02/10] net/tap: replace runtime speed capability with constant Stephen Hemminger
2026-02-20 5:02 ` Stephen Hemminger [this message]
2026-02-20 5:02 ` [PATCH v3 04/10] net/tap: extend fixed MAC range to 16 bits Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 05/10] net/tap: skip checksum on truncated L4 headers Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 06/10] net/tap: fix resource leaks in tap create error path Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 07/10] net/tap: fix resource leaks in secondary process probe Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 08/10] net/tap: free IPC reply buffer on queue count mismatch Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 09/10] net/tap: fix use-after-free on remote flow creation failure Stephen Hemminger
2026-02-20 5:02 ` [PATCH v3 10/10] net/tap: free remote flow when implicit rule already exists Stephen Hemminger
2026-02-20 17:02 ` [PATCH 00/10] net/tap: cleanups and bug fixes Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 01/10] net/tap: replace runtime speed capability with constant Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 02/10] net/tap: clarify TUN/TAP flag assignment Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 03/10] net/tap: extend fixed MAC range to 16 bits Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 04/10] net/tap: skip checksum on truncated L4 headers Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 05/10] net/tap: fix resource leaks in tap create error path Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 06/10] net/tap: fix resource leaks in secondary process probe Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 07/10] net/tap: free IPC reply buffer on queue count mismatch Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 08/10] net/tap: fix use-after-free on remote flow creation failure Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 09/10] net/tap: free remote flow when implicit rule already exists Stephen Hemminger
2026-02-20 17:02 ` [PATCH v4 10/10] test: add unit tests for TAP PMD Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 00/19] net/tap: cleanups, bug fixes, and VLA removal Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 01/19] net/tap: fix handling of queue stats Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 02/19] doc: update tap features Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 03/19] net/tap: use correct length for interface names Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 04/19] net/tap: replace runtime speed capability with constant Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 05/19] net/tap: clarify TUN/TAP flag assignment Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 06/19] net/tap: extend fixed MAC range to 16 bits Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 07/19] net/tap: skip checksum on truncated L4 headers Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 08/19] net/tap: fix resource leaks in tap create error path Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 09/19] net/tap: fix resource leaks in secondary process probe Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 10/19] net/tap: free IPC reply buffer on queue count mismatch Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 11/19] net/tap: fix use-after-free on remote flow creation failure Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 12/19] net/tap: free remote flow when implicit rule already exists Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 13/19] net/tap: dynamically allocate queue structures Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 14/19] net/tap: remove VLA in flow item validation Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 15/19] net/tap: fix Rx descriptor vs scatter segment confusion Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 16/19] net/tap: replace use of VLA in transmit burst Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 17/19] net/tap: consolidate queue statistics Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 18/19] net/tap: enable VLA warnings Stephen Hemminger
2026-02-22 17:30 ` [PATCH v5 19/19] test: add unit tests for TAP PMD Stephen Hemminger
2026-03-16 8:03 ` David Marchand
2026-02-25 23:18 ` [PATCH v5 00/19] net/tap: cleanups, bug fixes, and VLA removal Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220050409.1571022-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox