public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
	Long Li <longli@microsoft.com>
Subject: Re: [RFC] net/vdev_netvsc: check for NetVSC device before auto-probe
Date: Sun, 22 Feb 2026 14:00:34 -0800	[thread overview]
Message-ID: <20260222140034.3675188e@phoenix.local> (raw)
In-Reply-To: <20260222204813.773962-1-stephen@networkplumber.org>

On Sun, 22 Feb 2026 12:48:13 -0800
Stephen Hemminger <stephen@networkplumber.org> wrote:

> The custom scan callback unconditionally injects net_vdev_netvsc into
> the devargs list on any Hyper-V system without checking whether NetVSC
> interfaces actually exist. This causes the eal_flags_vdev_opt_autotest
> to fail on GitHub Actions runners (which are Azure/Hyper-V VMs) because
> the vdev bus probes both the test's intended vdev and the injected
> net_vdev_netvsc, which fails to initialize on systems without NetVSC
> interfaces.
> 
> Check whether at least one NetVSC interface exists (via the sysfs
> class_id check the driver already uses) before adding devargs in the
> scan callback.
> 
> Fixes: 56252de779a6 ("net/vdev_netvsc: add automatic probing")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

This is not sufficient to fix the github problem.
The container still has an interface, and cloud-init has given it
an address. But it has no route to outside (in container).

It looks like the whole automagic vdev_netvsc model is so brittle
it should be removed.

  reply	other threads:[~2026-02-22 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22 20:48 [RFC] net/vdev_netvsc: check for NetVSC device before auto-probe Stephen Hemminger
2026-02-22 22:00 ` Stephen Hemminger [this message]
2026-02-23 21:42   ` [EXTERNAL] " Long Li
2026-02-23 23:01     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260222140034.3675188e@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=longli@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox