From: Stephen Hemminger <stephen@networkplumber.org>
To: longli@linux.microsoft.com
Cc: dev@dpdk.org, Wei Hu <weh@microsoft.com>,
stable@dpdk.org, Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Long Li <longli@microsoft.com>
Subject: Re: [PATCH v2 2/8] net/netvsc: fix race conditions on VF add/remove events
Date: Mon, 23 Feb 2026 09:40:04 -0800 [thread overview]
Message-ID: <20260223094004.445914ee@phoenix.local> (raw)
In-Reply-To: <20260221024540.659098-2-longli@linux.microsoft.com>
On Fri, 20 Feb 2026 18:45:21 -0800
longli@linux.microsoft.com wrote:
> + rte_rwlock_read_lock(&hv->vf_lock);
> + vf_dev = hn_get_vf_dev(hv);
> + if (hv->vf_ctx.vf_vsc_switched && vf_dev &&
> + vf_dev->data->dev_started) {
> + void *sub_q = vf_dev->data->tx_queues[queue_id];
> +
> + nb_tx = (*vf_dev->tx_pkt_burst)
> + (sub_q, tx_pkts, nb_pkts);
> rte_rwlock_read_unlock(&hv->vf_lock);
> + return nb_tx;
> }
> + rte_rwlock_read_unlock(&hv->vf_lock);
ok, but read locks not free. It does incur an additional cache miss
which may impact performance.
Might be better in future to have some form of lockless access here.
next prev parent reply other threads:[~2026-02-23 17:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 2:45 [PATCH v2 1/8] net/netvsc: secondary ignore promiscuous enable/disable longli
2026-02-21 2:45 ` [PATCH v2 2/8] net/netvsc: fix race conditions on VF add/remove events longli
2026-02-23 17:40 ` Stephen Hemminger [this message]
2026-02-23 17:43 ` Stephen Hemminger
2026-02-23 22:31 ` [EXTERNAL] " Long Li
2026-02-21 2:45 ` [PATCH v2 3/8] net/netvsc: add multi-process VF device removal support longli
2026-02-23 17:45 ` Stephen Hemminger
2026-02-23 22:32 ` [EXTERNAL] " Long Li
2026-02-21 2:45 ` [PATCH v2 4/8] net/mana: fix PD resource leak on device close longli
2026-02-21 2:45 ` [PATCH v2 5/8] net/netvsc: fix devargs memory leak on hotplug longli
2026-02-21 2:45 ` [PATCH v2 6/8] net/mana: fix fast-path ops setup in secondary process longli
2026-02-21 2:45 ` [PATCH v2 7/8] net/mlx5: " longli
2026-02-21 2:45 ` [PATCH v2 8/8] net/mlx4: " longli
2026-02-21 5:16 ` [PATCH v2 1/8] net/netvsc: secondary ignore promiscuous enable/disable Stephen Hemminger
2026-02-23 23:25 ` [EXTERNAL] " Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223094004.445914ee@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=longli@linux.microsoft.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox