Re: [PATCH v2 00/17] net/dpaa2: fixes and improvements

David Marchand
2026-03-05T16:55:57Z

On Thu, 26 Feb 2026 at 20:26, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 26 Feb 2026 15:33:24 +0100
> Maxime Leroy <maxime@leroys.fr> wrote:
>
> > Various fixes and improvements for the dpaa2 net driver and fslmc bus.
> >
> > Patches 1-6 fix resource leaks on port close, error paths, link status
> > and devargs propagation on hotplug.
> >
> > Patches 7-14 fix additional bugs: spurious VLAN insertion, error packet
> > dump crash, packet type classification, checksum offload flags, software
> > taildrop buffer access, burst mode info reporting, SG table walk bounds,
> > and MAC stats DMA allocation.
> >
> > Patch 15 is a minor cleanup in the link status area.
> >
> > Patches 16-17 add devargs alternatives for getenv-based configuration
> > of taildrop and data stashing options.
> >
> > Changes since v1:
> > - Add Cc: stable@dpdk.org on patches with Fixes: tags (Stephen)
> > - Reorder series: fixes first, then improvements (Stephen)
> > - Patch 2: squash with former patch 4 (Hemant)
> > - Patch 6: move devargs refresh from plug to scan rescan path (David)
> > - Patch 17: keep getenv for backward compatibility, add devargs as
> > alternative instead of replacement
> > - Drop former patch 11 (bus/fslmc: remove dead blocklist check) to
> > avoid disaligning with other buses (David)
> > - New patches 8, 11-14 fixing issues reported by Stephen
> > - New patches 7, 9-10 fixing VLAN insertion and packet classification
> > issues
> >
> > Maxime Leroy (17):
> > net/dpaa2: fix queue block memory leak on port close
> > net/dpaa2: fix rx error queue memory leaks
> > net/dpaa2: warn on rx descriptor limit only in high perf buffer mode
> > net/dpaa2: fix resource leak on softparser failure
> > net/dpaa2: fix link not up after port stop/start
> > bus/fslmc: fix devargs not propagated on hotplug
> > net/dpaa2: fix spurious VLAN insertion on non-VLAN packets
> > net/dpaa2: fix error packet dump crash and memory leak
> > net/dpaa2: fix L4 packet type classification in slow parse path
> > net/dpaa2: fix L3/L4 checksum offload flags
> > net/dpaa2: fix software taildrop buffer access
> > net/dpaa2: fix burst mode info to report active burst function
> > net/dpaa2: add SG table walk upper bound in Rx path
> > net/dpaa2: fix MAC stats DMA buffer allocation per xstats call
> > net/dpaa2: use CHECK_INTERVAL macro in set_link_down
> > net/dpaa2: add devargs to disable Rx taildrop
> > net/dpaa2: add devargs alternative for data stashing getenv
> >
> > drivers/bus/fslmc/fslmc_bus.c | 4 +
> > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 16 +-
> > drivers/net/dpaa2/dpaa2_ethdev.c | 211 ++++++++++++------------
> > drivers/net/dpaa2/dpaa2_ethdev.h | 3 +
> > drivers/net/dpaa2/dpaa2_rxtx.c | 85 +++++-----
> > drivers/net/dpaa2/mc/fsl_dpni.h | 6 +
> > 6 files changed, 164 insertions(+), 161 deletions(-)
> >
>
> Please fix the free bulk bug on Transmit and revise

As I replied in other thread, I see no bug on usage of free bulk (not
the raw helper).

> patches so that check-git-log.sh does not complain so much.

Maxime, this will need a new revision on those warnings.

Hemant, in the mean time, could NXP review/test on real hw?

Thanks.

--
David Marchand