Re: [PATCH v3 00/17] net/dpaa2: fixes and improvements

Hemant Agrawal
2026-03-24T05:19:40Z

Hi Maxime,

On 09-03-2026 15:59, Hemant Agrawal wrote:
>
> On 09-03-2026 15:15, Maxime Leroy wrote:
>> Le ven. 6 mars 2026 à 19:51, Stephen Hemminger
>> <stephen@networkplumber.org> a écrit :
>>> On Fri,  6 Mar 2026 14:30:18 +0100
>>> Maxime Leroy <maxime@leroys.fr> wrote:
>>>
>>>> Various fixes and improvements for the dpaa2 net driver and fslmc bus.
>>>>
>>>> Patches 1-6 fix resource leaks on port close, error paths, link status
>>>> and devargs propagation on hotplug.
>>>>
>>>> Patches 7-14 fix additional bugs: spurious VLAN insertion, error
>>>> packet
>>>> dump crash, packet type classification, checksum offload flags,
>>>> software
>>>> taildrop buffer access, burst mode info reporting, SG table walk
>>>> bounds,
>>>> and MAC stats DMA allocation.
>>>>
>>>> Patch 15 is a minor cleanup in the link status area.
>>>>
>>>> Patches 16-17 add devargs alternatives for getenv-based configuration
>>>> of taildrop and data stashing options.
>>>>
>>>> Changes since v2:
>>>> - Fix checkpatch warnings: short SHA in Fixes tag (patch 14),
>>>>    long line in commit message (patch 10)
>>>> - Fix check-git-log warnings: shorten headlines (patches 3, 9, 12,
>>>> 14),
>>>>    fix tag order Fixes/Cc (patches 10, 11), fix wrong Fixes reference
>>>>    (patch 8), remove colon after function name in commit body
>>>> (patch 8),
>>>>    lowercase macro name in headline (patch 15)
>>>>
>>>> Changes since v1:
>>>> - Add Cc: stable@dpdk.org on patches with Fixes: tags (Stephen)
>>>> - Reorder series: fixes first, then improvements (Stephen)
>>>> - Patch 2: squash with former patch 4 (Hemant)
>>>> - Patch 6: move devargs refresh from plug to scan rescan path (David)
>>>> - Patch 17: keep getenv for backward compatibility, add devargs as
>>>>    alternative instead of replacement
>>>> - Drop former patch 11 (bus/fslmc: remove dead blocklist check) to
>>>>    avoid disaligning with other buses (David)
>>>> - New patches 8, 11-14 fixing issues reported by Stephen
>>>> - New patches 7, 9-10 fixing VLAN insertion and packet classification
>>>>    issues
>>>>
>>>> Maxime Leroy (17):
>>>>    net/dpaa2: fix queue block memory leak on port close
>>>>    net/dpaa2: fix Rx error queue memory leaks
>>>>    net/dpaa2: warn on Rx descriptor limit in high perf mode
>>>>    net/dpaa2: fix resource leak on softparser failure
>>>>    net/dpaa2: fix link not up after port stop/start
>>>>    bus/fslmc: fix devargs not propagated on hotplug
>>>>    net/dpaa2: fix spurious VLAN insertion on non-VLAN packets
>>>>    net/dpaa2: fix error packet dump crash and memory leak
>>>>    net/dpaa2: fix L4 packet type in slow parse path
>>>>    net/dpaa2: fix L3/L4 checksum offload flags
>>>>    net/dpaa2: fix software taildrop buffer access
>>>>    net/dpaa2: fix burst mode info report
>>>>    net/dpaa2: add SG table walk upper bound in Rx path
>>>>    net/dpaa2: fix MAC stats DMA alloc per xstats call
>>>>    net/dpaa2: use check interval macro in link down path
>>>>    net/dpaa2: add devargs to disable Rx taildrop
>>>>    net/dpaa2: add devargs alternative for data stashing getenv
>>>>
>>>>   drivers/bus/fslmc/fslmc_bus.c           |   4 +
>>>>   drivers/bus/fslmc/portal/dpaa2_hw_pvt.h |  16 +-
>>>>   drivers/net/dpaa2/dpaa2_ethdev.c        | 211
>>>> ++++++++++++------------
>>>>   drivers/net/dpaa2/dpaa2_ethdev.h        |   3 +
>>>>   drivers/net/dpaa2/dpaa2_rxtx.c          |  85 +++++-----
>>>>   drivers/net/dpaa2/mc/fsl_dpni.h         |   6 +
>>>>   6 files changed, 164 insertions(+), 161 deletions(-)
>>>>
>>> Applied to next-net, minor edits to first commit message to fix
>>> the reference commit; problem reported by checkpatches
>> Hi Stephen,
>>
>> Thanks for the merge. However, I was not expecting the series to be
>> merged without an ACK from NXP maintainers.
>> Many of the issues were found through code review only and marked as
>> “not tested”, with only minimal runtime checks on my side. I would
>> feel more comfortable with an ACK from NXP.
>>
>> Hemant, could you please take a look at the series when you have a
>> chance?
> Yes, we will be testing it soon.
Once you address my other comment, you can add my ack to the series.

Series-

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

>> Thanks,
>>
>> Maxime