Re: [PATCH 11/11] bus/fslmc: remove dead blocklist check in plug path

David Marchand
2026-02-18T17:01:30Z

On Wed, 18 Feb 2026 at 17:06, Maxime Leroy <maxime@leroys.fr> wrote:
>
> The plug callback is only reached via rte_dev_probe() which adds the
> device to the EAL devargs list with RTE_DEV_ALLOWED policy. There is
> no way to reach fslmc_bus_plug() with a blocked device, making the
> blocklist check dead code.
>
> Remove it.
>
> Fixes: b5721f271cbf ("bus/fslmc: support DPNI hotplug")
> Signed-off-by: Maxime Leroy <maxime@leroys.fr>

Checking for RTE_DEV_BLOCKED does not seem needed as the scanning part
will affect this bus device list first.
The strange thing is that it is probably consistent with other buses...

The scan/probe code would need some cleanup / consolidation on the EAL
side, but that's a separate topic.

Overall, this change does not seem wrong, my only concern is
disaligning with other buses.

--
David Marchand