From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v3 0/5] pcapng: fixes for Windows and timestamps
Date: Sat, 28 Feb 2026 09:34:59 -0800 [thread overview]
Message-ID: <20260228175601.585102-1-stephen@networkplumber.org> (raw)
In-Reply-To: <20260220184255.306368-1-stephen@networkplumber.org>
Fix pcapng test and library issues:
The test did not build on Windows because it used POSIX-only
APIs (clock_gettime, mkstemps, unlink). Add Windows wrappers
and use portable alternatives where possible.
The test timing was tied to TSC frequency which could make
it run excessively long on slow emulated platforms. Use a
fixed time bound instead.
The test was mixing stdout and stderr making CI log analysis
confusing. Consolidate on stdout and switch to UTC timestamps.
The library timestamp conversion produced bogus values if
rte_pcapng_copy() was called before rte_pcapng_fdopen(),
since the unsigned TSC delta wraps. Handle the case where
the packet TSC precedes the clock baseline.
Add a regression test for the pre-open timestamp fix.
v3 - improve test log output
Stephen Hemminger (5):
test: fix pcapng test to work on Windows
test: use fixed time length for write packet test
test: better logging for pcapng test
pcapng: handle packets copied before file open
test: add pcapng test for copy before open
app/test/test_pcapng.c | 224 ++++++++++++++++++++++++++++++++++------
lib/pcapng/rte_pcapng.c | 10 +-
2 files changed, 197 insertions(+), 37 deletions(-)
--
2.51.0
next prev parent reply other threads:[~2026-02-28 17:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 18:41 [PATCH 0/2] pcapng: bug fixes Stephen Hemminger
2026-02-20 18:41 ` [PATCH 1/2] test: fix pcapng test to work on Windows Stephen Hemminger
2026-02-20 18:41 ` [PATCH 2/2] pcapng: handle packets copied before file open Stephen Hemminger
2026-02-24 15:25 ` [PATCH v2 0/4] pcapng: fix test and copy before open Stephen Hemminger
2026-02-24 15:25 ` [PATCH v2 1/4] test: fix pcapng test to work on Windows Stephen Hemminger
2026-02-24 15:25 ` [PATCH v2 2/4] pcapng: handle packets copied before file open Stephen Hemminger
2026-02-24 15:25 ` [PATCH v2 3/4] test: add pcapng test for copy before open Stephen Hemminger
2026-02-24 15:25 ` [PATCH v2 4/4] test: use fixed time length for write packet test Stephen Hemminger
2026-02-25 22:57 ` [PATCH v3 0/4] pcapng: enhancements and test fix Stephen Hemminger
2026-02-25 22:57 ` [PATCH v3 1/4] test: fix pcapng test to work on Windows Stephen Hemminger
2026-02-25 22:57 ` [PATCH v3 2/4] test: use fixed time length for write packet test Stephen Hemminger
2026-02-25 22:57 ` [PATCH v3 3/4] pcapng: handle packets copied before file open Stephen Hemminger
2026-02-25 22:57 ` [PATCH v3 4/4] test: add pcapng test for copy before open Stephen Hemminger
2026-02-28 17:34 ` Stephen Hemminger [this message]
2026-02-28 17:35 ` [PATCH v3 1/5] test: fix pcapng test to work on Windows Stephen Hemminger
2026-02-28 17:35 ` [PATCH v3 2/5] test: use fixed time length for write packet test Stephen Hemminger
2026-02-28 17:35 ` [PATCH v3 3/5] test: better logging for pcapng test Stephen Hemminger
2026-02-28 17:35 ` [PATCH v3 4/5] pcapng: handle packets copied before file open Stephen Hemminger
2026-03-19 10:34 ` Kevin Traynor
2026-03-31 18:07 ` Stephen Hemminger
2026-02-28 17:35 ` [PATCH v3 5/5] test: add pcapng test for copy before open Stephen Hemminger
2026-03-17 10:38 ` [PATCH v3 0/5] pcapng: fixes for Windows and timestamps Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228175601.585102-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox