public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
* [PATCH 0/2] eventdev: fix eth dev ID truncation in telemetry
@ 2026-03-04  0:34 Sergei Iashin
  2026-03-04  0:34 ` [PATCH 1/2] " Sergei Iashin
  2026-03-04  0:34 ` [PATCH 2/2] mailmap: add Sergei Iashin Sergei Iashin
  0 siblings, 2 replies; 4+ messages in thread
From: Sergei Iashin @ 2026-03-04  0:34 UTC (permalink / raw)
  Cc: dev, Sergei Iashin

This series fixes an out-of-bounds access in eventdev rx adapter telemetry
handlers caused by eth dev ID truncation.

Patches:
- eventdev: fix eth dev ID truncation in telemetry
- mailmap: add Sergei Iashin

Sergei Iashin (2):
  eventdev: fix eth dev ID truncation in telemetry
  mailmap: add Sergei Iashin

 .mailmap                                |  1 +
 lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.39.5


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] eventdev: fix eth dev ID truncation in telemetry
  2026-03-04  0:34 [PATCH 0/2] eventdev: fix eth dev ID truncation in telemetry Sergei Iashin
@ 2026-03-04  0:34 ` Sergei Iashin
  2026-03-04  0:34 ` [PATCH 2/2] mailmap: add Sergei Iashin Sergei Iashin
  1 sibling, 0 replies; 4+ messages in thread
From: Sergei Iashin @ 2026-03-04  0:34 UTC (permalink / raw)
  To: Naga Harish K S V, Jerin Jacob, Jay Jayatheerthan,
	Ganapati Kundapura, Weiguo Li
  Cc: dev, Sergei Iashin, liwg06, stable

eth_dev_id is declared as int in handle_rxa_get_queue_conf(),
handle_rxa_get_queue_stats(), handle_rxa_queue_stats_reset(), and
handle_rxa_instance_get(), but is implicitly narrowed to uint16_t when
passed to rte_eth_dev_is_valid_port() via
RTE_EVENT_ETH_RX_ADAPTER_PORTID_VALID_OR_GOTO_ERR_RET().
A value like 65535 + N passes validation as N, but is then used as-is as
an array index, causing out-of-bounds access and SIGSEGV.

To reproduce (requires telemetry enabled):
  echo "/eventdev/rxa_queue_conf,0,65536,0" | \
    socat - UNIX-CONNECT:/var/run/dpdk/vpp/dpdk_telemetry.v2,type=5

Result:
  SIGSEGV at handle_rxa_get_queue_conf + 0x34a, faulting address 0x50

This patch changes eth_dev_id from int to uint16_t to avoid truncation.

Fixes: 74b034ff8172 ("eventdev/eth_rx: fix parameters parsing memory leak")
Cc: liwg06@foxmail.com
Cc: stable@dpdk.org

Signed-off-by: Sergei Iashin <yashin.sergey@gmail.com>
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index d564e14b72..2183adce6f 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3827,7 +3827,8 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
 {
 	uint8_t rx_adapter_id;
 	uint16_t rx_queue_id;
-	int eth_dev_id, ret = -1;
+	uint16_t eth_dev_id;
+	int ret = -1;
 	char *token, *l_params;
 	struct rte_event_eth_rx_adapter_queue_conf queue_conf;
 
@@ -3899,7 +3900,8 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
 {
 	uint8_t rx_adapter_id;
 	uint16_t rx_queue_id;
-	int eth_dev_id, ret = -1;
+	uint16_t eth_dev_id;
+	int ret = -1;
 	char *token, *l_params;
 	struct rte_event_eth_rx_adapter_queue_stats q_stats;
 
@@ -3970,7 +3972,8 @@ handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
 {
 	uint8_t rx_adapter_id;
 	uint16_t rx_queue_id;
-	int eth_dev_id, ret = -1;
+	uint16_t eth_dev_id;
+	int ret = -1;
 	char *token, *l_params;
 
 	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -4031,7 +4034,8 @@ handle_rxa_instance_get(const char *cmd __rte_unused,
 {
 	uint8_t instance_id;
 	uint16_t rx_queue_id;
-	int eth_dev_id, ret = -1;
+	uint16_t eth_dev_id;
+	int ret = -1;
 	char *token, *l_params;
 
 	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] mailmap: add Sergei Iashin
  2026-03-04  0:34 [PATCH 0/2] eventdev: fix eth dev ID truncation in telemetry Sergei Iashin
  2026-03-04  0:34 ` [PATCH 1/2] " Sergei Iashin
@ 2026-03-04  0:34 ` Sergei Iashin
  2026-03-24 17:34   ` Jerin Jacob
  1 sibling, 1 reply; 4+ messages in thread
From: Sergei Iashin @ 2026-03-04  0:34 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Sergei Iashin

Add my name and email mapping to .mailmap

Signed-off-by: Sergei Iashin <yashin.sergey@gmail.com>
---
 .mailmap | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 6c4c977dde..85db3c11af 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1936,3 +1936,4 @@ Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
 Zorik Machulsky <zorik@amazon.com>
 Zyta Szpak <zyta@marvell.com> <zr@semihalf.com>
 Zyta Szpak <zyta@marvell.com> <zyta.szpak@semihalf.com>
+Sergei Iashin <yashin.sergey@gmail.com>
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] mailmap: add Sergei Iashin
  2026-03-04  0:34 ` [PATCH 2/2] mailmap: add Sergei Iashin Sergei Iashin
@ 2026-03-24 17:34   ` Jerin Jacob
  0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2026-03-24 17:34 UTC (permalink / raw)
  To: Sergei Iashin; +Cc: Thomas Monjalon, dev

On Wed, Mar 4, 2026 at 8:46 PM Sergei Iashin <yashin.sergey@gmail.com> wrote:
>
> Add my name and email mapping to .mailmap
>
> Signed-off-by: Sergei Iashin <yashin.sergey@gmail.com>
> ---
>  .mailmap | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/.mailmap b/.mailmap
> index 6c4c977dde..85db3c11af 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -1936,3 +1936,4 @@ Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
>  Zorik Machulsky <zorik@amazon.com>
>  Zyta Szpak <zyta@marvell.com> <zr@semihalf.com>
>  Zyta Szpak <zyta@marvell.com> <zyta.szpak@semihalf.com>
> +Sergei Iashin <yashin.sergey@gmail.com>

Fixed the name order by making it as alphabetical
Squashed with 1/2 patch
Applied to dpdk-next-eventdev/for-main. Thanks


> --
> 2.39.5
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-24 17:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04  0:34 [PATCH 0/2] eventdev: fix eth dev ID truncation in telemetry Sergei Iashin
2026-03-04  0:34 ` [PATCH 1/2] " Sergei Iashin
2026-03-04  0:34 ` [PATCH 2/2] mailmap: add Sergei Iashin Sergei Iashin
2026-03-24 17:34   ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox