public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: <dev@dpdk.org>
Cc: <david.marchand@redhat.com>
Subject: [PATCH] devtools: fix symbol change check for non-lib patches
Date: Thu, 5 Mar 2026 11:10:39 +0200	[thread overview]
Message-ID: <20260305091039.1057276-1-alialnu@nvidia.com> (raw)

Initialize lib var per patch file and skip symbol handling when no
lib/drivers file header was seen. Avoids NameError exception when
processing patches that only touch docs or other paths.

Fixes: 1a0c104a7fa9 ("build: generate symbol maps")
Cc: david.marchand@redhat.com

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
 devtools/check-symbol-change.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/devtools/check-symbol-change.py b/devtools/check-symbol-change.py
index 1efeb82fcd..4cee4c765c 100755
--- a/devtools/check-symbol-change.py
+++ b/devtools/check-symbol-change.py
@@ -29,6 +29,7 @@
 symbols = {}
 
 for file in args.patch:
+    lib = None
     for ln in file.readlines():
         if file_header_regexp.match(ln):
             if file_header_regexp.match(ln).group(2) == "lib":
@@ -54,6 +55,8 @@
         else:
             continue
 
+        if lib is None:
+            continue
         if symbol not in symbols[lib]:
             symbols[lib][symbol] = {}
         added = ln[0] == "+"
-- 
2.53.0


             reply	other threads:[~2026-03-05  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  9:10 Ali Alnubani [this message]
2026-03-05 10:10 ` [PATCH] devtools: fix symbol change check for non-lib patches David Marchand
2026-03-05 10:50 ` [PATCH v2] " Ali Alnubani
2026-03-05 13:50   ` David Marchand
2026-03-09 15:08   ` [PATCH v3] " Ali Alnubani
2026-03-17 15:45     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305091039.1057276-1-alialnu@nvidia.com \
    --to=alialnu@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox