From: AKSHATHA S <akshathax.s@intel.com>
To: dev@dpdk.org, bruce.richardson@intel.com, aman.deep.singh@intel.com
Cc: shaiq.wani@intel.com, AKSHATHA S <akshathax.s@intel.com>
Subject: [PATCH] net/e1000: align igb link update for consistency
Date: Thu, 5 Mar 2026 16:51:41 +0000 [thread overview]
Message-ID: <20260305165142.89960-1-akshathax.s@intel.com> (raw)
The igb PMD currently updates auto-neg status only during specific
link transitions. Updated auto-neg status regardless of link transition.
Signed-off-by: AKSHATHA S <akshathax.s@intel.com>
---
drivers/net/intel/e1000/igb_ethdev.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/intel/e1000/igb_ethdev.c b/drivers/net/intel/e1000/igb_ethdev.c
index 1f51ba6406..ef1599ac38 100644
--- a/drivers/net/intel/e1000/igb_ethdev.c
+++ b/drivers/net/intel/e1000/igb_ethdev.c
@@ -2568,14 +2568,13 @@ eth_igb_link_update(struct rte_eth_dev *dev, int wait_to_complete)
RTE_ETH_LINK_HALF_DUPLEX;
link.link_speed = speed;
link.link_status = RTE_ETH_LINK_UP;
- link.link_autoneg = !(dev->data->dev_conf.link_speeds &
- RTE_ETH_LINK_SPEED_FIXED);
} else if (!link_check) {
link.link_speed = 0;
link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX;
link.link_status = RTE_ETH_LINK_DOWN;
- link.link_autoneg = RTE_ETH_LINK_FIXED;
}
+ link.link_autoneg = !(dev->data->dev_conf.link_speeds &
+ RTE_ETH_LINK_SPEED_FIXED);
return rte_eth_linkstatus_set(dev, &link);
}
--
2.43.0
next reply other threads:[~2026-03-05 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 16:51 AKSHATHA S [this message]
2026-03-06 23:36 ` [PATCH v2] net/e1000: align link updates in em igb and igc AKSHATHA S
2026-03-09 9:29 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305165142.89960-1-akshathax.s@intel.com \
--to=akshathax.s@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox