From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, stable@dpdk.org
Subject: [PATCH v4 04/11] test/stack: scale test based on number of cores
Date: Thu, 5 Mar 2026 09:50:58 -0800 [thread overview]
Message-ID: <20260305175326.279891-5-stephen@networkplumber.org> (raw)
In-Reply-To: <20260305175326.279891-1-stephen@networkplumber.org>
This test uses loops to synchronize but has problems on systems
with high number of cores. Scale iterations to the number of
cores.
Fixes: 5e2e61b99e91 ("test/stack: check stack API")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_stack.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index abc3114729..5517982774 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -268,10 +268,12 @@ test_free_null(void)
return 0;
}
-#define NUM_ITERS_PER_THREAD 100000
+#define NUM_ITERS_BASE 100000u
+#define NUM_ITERS_MIN 1000u
struct test_args {
struct rte_stack *s;
+ unsigned int num_iters;
};
static struct test_args thread_test_args;
@@ -280,9 +282,9 @@ static int
stack_thread_push_pop(__rte_unused void *args)
{
void *obj_table[MAX_BULK];
- int i;
+ unsigned int i;
- for (i = 0; i < NUM_ITERS_PER_THREAD; i++) {
+ for (i = 0; i < thread_test_args.num_iters; i++) {
unsigned int num;
num = rte_rand() % MAX_BULK;
@@ -308,12 +310,14 @@ test_stack_multithreaded(uint32_t flags)
{
unsigned int lcore_id;
struct rte_stack *s;
+ unsigned int iterations;
int result = 0;
if (rte_lcore_count() < 2) {
printf("Not enough cores for test_stack_multithreaded, expecting at least 2\n");
return TEST_SKIPPED;
}
+ iterations = test_scale_iterations(NUM_ITERS_BASE, NUM_ITERS_MIN);
printf("[%s():%u] Running with %u lcores\n",
__func__, __LINE__, rte_lcore_count());
@@ -325,6 +329,7 @@ test_stack_multithreaded(uint32_t flags)
return -1;
}
+ thread_test_args.num_iters = iterations;
thread_test_args.s = s;
if (rte_eal_mp_remote_launch(stack_thread_push_pop, NULL, CALL_MAIN))
--
2.51.0
next prev parent reply other threads:[~2026-03-05 17:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 20:09 [PATCH 0/6] test: fix sporadic failures on high core count systems Stephen Hemminger
2026-01-18 20:09 ` [PATCH 1/6] test: add pause to synchronization spinloops Stephen Hemminger
2026-01-18 20:09 ` [PATCH 2/6] test: fix timeout for atomic test on high core count systems Stephen Hemminger
2026-01-18 20:09 ` [PATCH 3/6] test: fix race condition in ELF load tests Stephen Hemminger
2026-01-19 11:42 ` Marat Khalili
2026-01-20 0:03 ` Stephen Hemminger
2026-01-20 10:30 ` Marat Khalili
2026-01-19 18:24 ` Stephen Hemminger
2026-01-18 20:09 ` [PATCH 4/6] test: fix unsupported BPF instructions in elf load test Stephen Hemminger
2026-01-19 11:43 ` Marat Khalili
2026-01-18 20:09 ` [PATCH 5/6] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-01-19 13:06 ` Marat Khalili
2026-01-19 14:01 ` Bruce Richardson
2026-01-18 20:09 ` [PATCH 6/6] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-01-19 13:13 ` Marat Khalili
2026-01-20 0:07 ` Stephen Hemminger
2026-01-20 11:36 ` Marat Khalili
2026-01-22 0:50 ` [PATCH v3 00/14] test: fix test failures on high cores Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 01/14] test: add pause to synchronization spinloops Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 02/14] test: scale atomic test based on core count Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 03/14] test/mcslock: scale test based on number of cores Stephen Hemminger
2026-01-22 10:41 ` Konstantin Ananyev
2026-01-27 20:31 ` Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 04/14] test/stack: " Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 05/14] test/timer: " Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 06/14] test/bpf: fix error handling in ELF load tests Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 07/14] test/bpf: fix unsupported BPF instructions in ELF load test Stephen Hemminger
2026-01-22 10:33 ` Konstantin Ananyev
2026-01-22 0:50 ` [PATCH v3 08/14] test/bpf: skip ELF test if null PMD disabled Stephen Hemminger
2026-01-23 11:56 ` Marat Khalili
2026-01-22 0:50 ` [PATCH v3 09/14] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 10/14] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 11/14] test/eventdev: skip test if eventdev driver disabled Stephen Hemminger
2026-01-22 20:40 ` Stephen Hemminger
2026-01-23 9:06 ` Bruce Richardson
2026-01-22 0:50 ` [PATCH v3 12/14] test/pcapng: skip test if null driver missing Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 13/14] test/vdev: skip test if no null PMD Stephen Hemminger
2026-01-22 0:50 ` [PATCH v3 14/14] test/bpf: pass correct size for Rx/Tx load tests Stephen Hemminger
2026-01-23 11:50 ` Marat Khalili
2026-03-05 16:39 ` [PATCH v3 00/14] test: fix test failures on high cores David Marchand
2026-03-05 17:50 ` [PATCH v4 00/11] test: fix test failures on high core count systems Stephen Hemminger
2026-03-05 17:50 ` [PATCH v4 01/11] test: add pause to synchronization spinloops Stephen Hemminger
2026-03-05 17:50 ` [PATCH v4 02/11] test/atomic: scale test based on core count Stephen Hemminger
2026-03-05 17:50 ` [PATCH v4 03/11] test/mcslock: scale test based on number of cores Stephen Hemminger
2026-03-05 17:50 ` Stephen Hemminger [this message]
2026-03-05 17:50 ` [PATCH v4 05/11] test/timer: " Stephen Hemminger
2026-03-05 17:51 ` [PATCH v4 06/11] test/timer: replace volatile with C11 atomics Stephen Hemminger
2026-03-05 17:51 ` [PATCH v4 07/11] test: add file-prefix for all fast-tests on Linux Stephen Hemminger
2026-03-05 17:51 ` [PATCH v4 08/11] test: fix trace_autotest_with_traces parallel execution Stephen Hemminger
2026-03-05 17:51 ` [PATCH v4 09/11] test/bpf: fix error handling in ELF load tests Stephen Hemminger
2026-03-05 17:51 ` [PATCH v4 10/11] test/bpf: fix unsupported BPF instructions in ELF load test Stephen Hemminger
2026-03-05 17:51 ` [PATCH v4 11/11] test/bpf: pass correct size for Rx/Tx load tests Stephen Hemminger
2026-03-17 13:28 ` [PATCH v4 00/11] test: fix test failures on high core count systems Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305175326.279891-5-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox