public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Anurag Mandal <anurag.mandal@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, anatoly.burakov@intel.com,
	alex.chapman@arm.com, Anurag Mandal <anurag.mandal@intel.com>,
	stable@dpdk.org
Subject: [PATCH] net/ice: fix rss simple_xor hash function
Date: Mon,  9 Mar 2026 02:32:55 +0000	[thread overview]
Message-ID: <20260309023255.308526-1-anurag.mandal@intel.com> (raw)

RSS Simple XOR hash function is supported by the NIC
as per datasheet & also in ICE Linux Ethernet kernel
driver but the same is not enabled in ICE PMD even
though code support is already present.

This patch fixes the issue by removing the simple_xor
check & adding proper error log for empty argument.

Bugzilla ID: 1518
Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow")
Cc: stable@dpdk.org

Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
---
 drivers/net/intel/ice/ice_hash.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/intel/ice/ice_hash.c b/drivers/net/intel/ice/ice_hash.c
index 77829e607b..d57b5ee0e4 100644
--- a/drivers/net/intel/ice/ice_hash.c
+++ b/drivers/net/intel/ice/ice_hash.c
@@ -1109,12 +1109,11 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
 			rss_type = rss->types;
 
 			/* Check hash function and save it to rss_meta. */
-			if (pattern_match_item->pattern_list !=
-			    pattern_empty && rss->func ==
-			    RTE_ETH_HASH_FUNCTION_SIMPLE_XOR) {
-				return rte_flow_error_set(error, ENOTSUP,
+			if (pattern_match_item->pattern_list ==
+			    pattern_empty) {
+				return rte_flow_error_set(error, EINVAL,
 					RTE_FLOW_ERROR_TYPE_ACTION, action,
-					"Not supported flow");
+					"Invalid empty argument");
 			} else if (rss->func ==
 				   RTE_ETH_HASH_FUNCTION_SIMPLE_XOR){
 				rss_meta->hash_function =
-- 
2.34.1


             reply	other threads:[~2026-03-09  2:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  2:32 Anurag Mandal [this message]
2026-03-09 10:19 ` [PATCH] net/ice: fix rss simple_xor hash function Burakov, Anatoly
2026-03-09 11:17   ` Mandal, Anurag
2026-03-09 11:48     ` Burakov, Anatoly
2026-03-09 13:26       ` Medvedkin, Vladimir
2026-03-16 11:10         ` Mandal, Anurag
2026-03-17 10:32 ` [PATCH v2] net/ice: fix RSS hash function implementation Anurag Mandal
2026-03-23 10:13   ` Mandal, Anurag
2026-03-23 17:55   ` Medvedkin, Vladimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309023255.308526-1-anurag.mandal@intel.com \
    --to=anurag.mandal@intel.com \
    --cc=alex.chapman@arm.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox