From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE86FD4F19 for ; Tue, 10 Mar 2026 19:17:32 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D190440E35; Tue, 10 Mar 2026 20:17:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6E86240E21 for ; Tue, 10 Mar 2026 20:17:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773170229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eniXkJtfSF2xzOvmFjw9D+wv/lX3azesHkv7Jie631Q=; b=DUggRQytn5V0a1uE4PoKmQj/sxivduXw7p8wUVJv+SwoiHBJ6ipZgcjHNXH+ja62txs65X a9iFOYTh+8BW8mbLD1G09pn6ElrAYDOW9p0o5oGnsU9ZgOyyV/kuXo/3Lp99y8DXOnzeQL if/6UdVB3kHrQgQzG9JuICn4GzbW/m0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-T2kj0JBDNyyijB-XGQzJkg-1; Tue, 10 Mar 2026 15:17:07 -0400 X-MC-Unique: T2kj0JBDNyyijB-XGQzJkg-1 X-Mimecast-MFC-AGG-ID: T2kj0JBDNyyijB-XGQzJkg_1773170226 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AE657195609F; Tue, 10 Mar 2026 19:17:06 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.44.32.202]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D07681956095; Tue, 10 Mar 2026 19:17:03 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: Maxime Coquelin Cc: david.marchand@redhat.com, mst@redhat.com, chenbox@nvidia.com, Yongji Xie , jasowang@redhat.com, dev@dpdk.org Subject: [RFC v2 05/10] vhost: add ASID support to VDUSE IOTLB operations Date: Tue, 10 Mar 2026 20:16:40 +0100 Message-ID: <20260310191645.1104892-6-eperezma@redhat.com> In-Reply-To: <20260310191645.1104892-1-eperezma@redhat.com> References: <20260310191645.1104892-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pmR5FMFKQg-hNUia8l7HOq1Givvyk1PhB9nAkTVcdRI_1773170226 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Maxime Coquelin Make use of the newly introduced address space ID when calling Vhost IOTLB API. Signed-off-by: Maxime Coquelin Signed-off-by: Eugenio Pérez --- Eugenio Pérez changes: * Use the new GET_FD2 ioctl. * Adapt the entry.v1 accesses to new format --- lib/vhost/vduse.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c index bb3a4363baad..4e1920f9441e 100644 --- a/lib/vhost/vduse.c +++ b/lib/vhost/vduse.c @@ -71,7 +71,7 @@ vduse_iotlb_remove_notify(uint64_t addr, uint64_t offset, uint64_t size) static int vduse_iotlb_miss(struct virtio_net *dev, int asid, uint64_t iova, uint8_t perm __rte_unused) { - struct vduse_iotlb_entry entry; + struct vduse_iotlb_entry_v2 entry = {}; uint64_t size, page_size; struct stat stat; void *mmap_addr; @@ -79,8 +79,9 @@ vduse_iotlb_miss(struct virtio_net *dev, int asid, uint64_t iova, uint8_t perm _ entry.start = iova; entry.last = iova + 1; + entry.asid = asid; - ret = ioctl(dev->vduse_dev_fd, VDUSE_IOTLB_GET_FD, &entry); + ret = ioctl(dev->vduse_dev_fd, VDUSE_IOTLB_GET_FD2, &entry); if (ret < 0) { VHOST_CONFIG_LOG(dev->ifname, ERR, "Failed to get IOTLB entry for 0x%" PRIx64, iova); @@ -90,6 +91,7 @@ vduse_iotlb_miss(struct virtio_net *dev, int asid, uint64_t iova, uint8_t perm _ fd = ret; VHOST_CONFIG_LOG(dev->ifname, DEBUG, "New IOTLB entry:"); + VHOST_CONFIG_LOG(dev->ifname, DEBUG, "\tASID: %d", entry.asid); VHOST_CONFIG_LOG(dev->ifname, DEBUG, "\tIOVA: %" PRIx64 " - %" PRIx64, (uint64_t)entry.start, (uint64_t)entry.last); VHOST_CONFIG_LOG(dev->ifname, DEBUG, "\toffset: %" PRIx64, (uint64_t)entry.offset); @@ -458,10 +460,24 @@ vduse_events_handler(int fd, void *arg, int *close __rte_unused) resp.result = VDUSE_REQ_RESULT_OK; break; case VDUSE_UPDATE_IOTLB: - VHOST_CONFIG_LOG(dev->ifname, INFO, "\tIOVA range: %" PRIx64 " - %" PRIx64, - (uint64_t)req.iova.start, (uint64_t)req.iova.last); - vhost_user_iotlb_cache_remove(dev, 0, req.iova.start, - req.iova.last - req.iova.start + 1); /* ToDo: use ASID once API available, using 0 for now */ + { + uint64_t start, last; + uint32_t asid; + + if (dev->vduse_api_ver < 1) { + start = req.iova.start; + last = req.iova.last; + asid = 0; + } else { + start = req.iova_v2.start; + last = req.iova_v2.last; + asid = req.iova_v2.asid; + } + + VHOST_CONFIG_LOG(dev->ifname, INFO, "\t(ASID %d) IOVA range: %" PRIx64 " - %" PRIx64, + asid, start, last); + vhost_user_iotlb_cache_remove(dev, asid, start, last - start + 1); + } resp.result = VDUSE_REQ_RESULT_OK; break; case VDUSE_SET_VQ_GROUP_ASID: -- 2.53.0