public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Talluri Chaitanyababu <chaitanyababux.talluri@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	aman.deep.singh@intel.com, shaiq.wani@intel.com, stable@dpdk.org
Subject: Re: [PATCH] app/testpmd: fix DCB forwarding TC mask and queue guard
Date: Wed, 11 Mar 2026 08:56:49 -0700	[thread overview]
Message-ID: <20260311085649.25c2c354@phoenix.local> (raw)
In-Reply-To: <20260311083751.1107404-1-chaitanyababux.talluri@intel.com>

On Wed, 11 Mar 2026 08:37:51 +0000
Talluri Chaitanyababu <chaitanyababux.talluri@intel.com> wrote:

> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index c33c66f327..3fb9b940eb 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3682,6 +3682,19 @@ cmd_config_dcb_parsed(void *parsed_result,
>  		return;
>  	}
>  
> +	/*
> +	 * Update forwarding TC mask to match actual configured TCs.
> +	 * Must query after init_port_dcb_config() to get updated nb_tcs.
> +	 */
> +	ret = rte_eth_dev_get_dcb_info(port_id, &dcb_info);
> +	if (ret == 0 && dcb_info.nb_tcs > 0) {
> +		dcb_fwd_tc_mask = (1u << dcb_info.nb_tcs) - 1;
> +	} else if (ret != 0) {
> +		fprintf(stderr, "Failed to get DCB info for port %u: %s\n",
> +				port_id, rte_strerror(-ret));
> +		return;
> +	}
> +

That function already called get_dcb_info only a few lines before?

  reply	other threads:[~2026-03-11 15:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  8:37 [PATCH] app/testpmd: fix DCB forwarding TC mask and queue guard Talluri Chaitanyababu
2026-03-11 15:56 ` Stephen Hemminger [this message]
2026-03-12 10:36 ` [PATCH v2] " Talluri Chaitanyababu
2026-03-12 18:44   ` Stephen Hemminger
2026-03-13  0:19   ` fengchengwen
2026-03-16  6:05     ` Talluri, ChaitanyababuX
2026-03-17  1:07       ` fengchengwen
2026-03-18  7:21         ` Talluri, ChaitanyababuX
2026-03-19  1:19           ` fengchengwen
2026-03-16  6:21 ` [PATCH v3] " Talluri Chaitanyababu
2026-03-17  1:23   ` fengchengwen
2026-03-17  8:57   ` Thomas Monjalon
2026-03-17  9:02     ` Thomas Monjalon
2026-03-18  6:17 ` [PATCH v4] app/testpmd: fix DCB forwarding TC mismatch handling Talluri Chaitanyababu
2026-03-19  1:35   ` fengchengwen
2026-03-20  6:29 ` [PATCH v5] " Talluri Chaitanyababu
2026-03-20  9:38   ` fengchengwen
2026-03-24  0:06   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311085649.25c2c354@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaitanyababux.talluri@intel.com \
    --cc=dev@dpdk.org \
    --cc=shaiq.wani@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox