From: John McNamara <john.mcnamara@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com,
John McNamara <john.mcnamara@intel.com>,
stable@dpdk.org
Subject: [PATCH v1] net/i40e: fix unused variable issue
Date: Wed, 11 Mar 2026 16:19:15 +0000 [thread overview]
Message-ID: <20260311161955.1833722-1-john.mcnamara@intel.com> (raw)
Fix issue where I40E_SUCCESS was assigned to a return variable
but was overwritten before it could be used.
Coverity issue: 501831
Fixes: baf1d4cd8aed ("net/i40e: upgrade AQ command of MAC/VLAN remove")
Cc: stable@dpdk.org
Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
drivers/net/intel/i40e/i40e_ethdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c
index af736f59be..100a751225 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -7243,9 +7243,7 @@ i40e_remove_macvlan_filters(struct i40e_vsi *vsi,
if (ret != I40E_SUCCESS) {
/* Do not report as an error when firmware returns ENOENT */
- if (aq_status == I40E_AQ_RC_ENOENT) {
- ret = I40E_SUCCESS;
- } else {
+ if (aq_status != I40E_AQ_RC_ENOENT) {
PMD_DRV_LOG(ERR, "Failed to remove macvlan filter");
return ret;
}
--
2.51.0
next reply other threads:[~2026-03-11 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 16:19 John McNamara [this message]
2026-03-18 10:58 ` [PATCH v1] net/i40e: fix unused variable issue Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260311161955.1833722-1-john.mcnamara@intel.com \
--to=john.mcnamara@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox