* [PATCH v1] net/i40e: fix unused variable issue
@ 2026-03-11 16:19 John McNamara
2026-03-18 10:58 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: John McNamara @ 2026-03-11 16:19 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, John McNamara, stable
Fix issue where I40E_SUCCESS was assigned to a return variable
but was overwritten before it could be used.
Coverity issue: 501831
Fixes: baf1d4cd8aed ("net/i40e: upgrade AQ command of MAC/VLAN remove")
Cc: stable@dpdk.org
Signed-off-by: John McNamara <john.mcnamara@intel.com>
---
drivers/net/intel/i40e/i40e_ethdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c
index af736f59be..100a751225 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -7243,9 +7243,7 @@ i40e_remove_macvlan_filters(struct i40e_vsi *vsi,
if (ret != I40E_SUCCESS) {
/* Do not report as an error when firmware returns ENOENT */
- if (aq_status == I40E_AQ_RC_ENOENT) {
- ret = I40E_SUCCESS;
- } else {
+ if (aq_status != I40E_AQ_RC_ENOENT) {
PMD_DRV_LOG(ERR, "Failed to remove macvlan filter");
return ret;
}
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] net/i40e: fix unused variable issue
2026-03-11 16:19 [PATCH v1] net/i40e: fix unused variable issue John McNamara
@ 2026-03-18 10:58 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2026-03-18 10:58 UTC (permalink / raw)
To: John McNamara; +Cc: dev, stable
On Wed, Mar 11, 2026 at 04:19:15PM +0000, John McNamara wrote:
> Fix issue where I40E_SUCCESS was assigned to a return variable
> but was overwritten before it could be used.
>
> Coverity issue: 501831
> Fixes: baf1d4cd8aed ("net/i40e: upgrade AQ command of MAC/VLAN remove")
> Cc: stable@dpdk.org
>
> Signed-off-by: John McNamara <john.mcnamara@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-net-net-intel.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-18 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 16:19 [PATCH v1] net/i40e: fix unused variable issue John McNamara
2026-03-18 10:58 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox