public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: dev@dpdk.org
Cc: Kevin Traynor <ktraynor@redhat.com>,
	stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbox@nvidia.com>,
	Ariel Otilibili <ariel.otilibili@6wind.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 1/4] vhost: fix resource leak
Date: Thu, 12 Mar 2026 10:36:03 +0000	[thread overview]
Message-ID: <20260312103606.702617-2-ktraynor@redhat.com> (raw)
In-Reply-To: <20260312103606.702617-1-ktraynor@redhat.com>

When the return value check for pthread_mutex_init() was removed the
out_free label and vhost_user_socket_mem_free() were removed.

The free is still needed as vsocket was not being freed on out_mutex
error path.

Restore vhost_user_socket_mem_free() on error path.

Fixes: 4d2aa150769b ("vhost: remove check around mutex init")
Cc: stable@dpdk.org

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 lib/vhost/socket.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index ae95e7e6b0..278a2c01d8 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -1037,4 +1037,5 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 		VHOST_CONFIG_LOG(path, ERR, "failed to destroy connection mutex");
 	}
+	vhost_user_socket_mem_free(vsocket);
 out:
 	pthread_mutex_unlock(&vhost_user.mutex);
-- 
2.53.0


  reply	other threads:[~2026-03-12 10:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 10:36 [PATCH 0/4] Static analysis fixes Kevin Traynor
2026-03-12 10:36 ` Kevin Traynor [this message]
2026-03-17 14:46   ` [PATCH 1/4] vhost: fix resource leak Maxime Coquelin
2026-03-12 10:36 ` [PATCH 2/4] net/bnxt: fix uninitialized read Kevin Traynor
2026-03-12 16:57   ` Stephen Hemminger
2026-03-16 18:39     ` Thomas Monjalon
2026-03-12 18:45   ` Kishore Padmanabha
2026-03-12 10:36 ` [PATCH 3/4] app/testpmd: check for no arguments Kevin Traynor
2026-03-12 12:37   ` fengchengwen
2026-03-12 17:03     ` Stephen Hemminger
2026-03-12 23:59       ` fengchengwen
2026-03-13  9:24         ` Kevin Traynor
2026-03-14  7:57           ` fengchengwen
2026-03-16  9:47             ` Kevin Traynor
2026-03-12 10:36 ` [PATCH 4/4] app/testpmd: fix fd leak Kevin Traynor
2026-03-17 15:52   ` Thomas Monjalon
2026-03-17 15:55 ` [PATCH 0/4] Static analysis fixes Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312103606.702617-2-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=ariel.otilibili@6wind.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox