From: Kevin Traynor <ktraynor@redhat.com>
To: dev@dpdk.org
Cc: Kevin Traynor <ktraynor@redhat.com>,
stable@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>
Subject: [PATCH 3/4] app/testpmd: check for no arguments
Date: Thu, 12 Mar 2026 10:36:05 +0000 [thread overview]
Message-ID: <20260312103606.702617-4-ktraynor@redhat.com> (raw)
In-Reply-To: <20260312103606.702617-1-ktraynor@redhat.com>
For the case where token is NULL, there are no arguments
and split_str[0] is used uninitialized.
Check counter to ensure there is a token and return error if not.
Fixes: 601576ae6699 ("app/testpmd: add prio-tc map in DCB command")
Cc: stable@dpdk.org
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test-pmd/cmdline.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index c33c66f327..ab85f4e0ad 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3570,4 +3570,9 @@ parse_dcb_token_value(char *token_str,
} while (1);
+ if (split_num == 0) {
+ fprintf(stderr, "Bad Argument: no arguments provided\n");
+ return -1;
+ }
+
/* parse fixed parameter "pfc-en" first. */
token = split_str[0];
--
2.53.0
next prev parent reply other threads:[~2026-03-12 10:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 10:36 [PATCH 0/4] Static analysis fixes Kevin Traynor
2026-03-12 10:36 ` [PATCH 1/4] vhost: fix resource leak Kevin Traynor
2026-03-17 14:46 ` Maxime Coquelin
2026-03-12 10:36 ` [PATCH 2/4] net/bnxt: fix uninitialized read Kevin Traynor
2026-03-12 16:57 ` Stephen Hemminger
2026-03-16 18:39 ` Thomas Monjalon
2026-03-12 18:45 ` Kishore Padmanabha
2026-03-12 10:36 ` Kevin Traynor [this message]
2026-03-12 12:37 ` [PATCH 3/4] app/testpmd: check for no arguments fengchengwen
2026-03-12 17:03 ` Stephen Hemminger
2026-03-12 23:59 ` fengchengwen
2026-03-13 9:24 ` Kevin Traynor
2026-03-14 7:57 ` fengchengwen
2026-03-16 9:47 ` Kevin Traynor
2026-03-12 10:36 ` [PATCH 4/4] app/testpmd: fix fd leak Kevin Traynor
2026-03-17 15:52 ` Thomas Monjalon
2026-03-17 15:55 ` [PATCH 0/4] Static analysis fixes Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260312103606.702617-4-ktraynor@redhat.com \
--to=ktraynor@redhat.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox