* [PATCH] net/idpf: fix comma operator warning
@ 2026-03-12 16:43 Stephen Hemminger
2026-03-12 16:57 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2026-03-12 16:43 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Jingjing Wu, Praveen Shetty, Shaiq Wani,
Bruce Richardson
Fix comma operator misuse warnings with clang compiler in idpf that
was missed in previous change. Shows up when -Wcomma enabled.
Fixes: 57560a92167a ("net/idpf: add AVX2 Tx path for split queue config")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/intel/idpf/idpf_common_rxtx_avx2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
index 4e1062f22d..db7728afad 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
@@ -842,7 +842,7 @@ idpf_splitq_vtx_avx2(struct idpf_flex_tx_sched_desc *txdp,
/* align if needed */
if (((uintptr_t)txdp & 0x1F) != 0 && nb_pkts != 0) {
idpf_splitq_vtx1_avx2(txdp, *pkt, flags);
- txdp++, pkt++, nb_pkts--;
+ txdp++; pkt++; nb_pkts--;
}
for (; nb_pkts >= IDPF_VPMD_DESCS_PER_LOOP; txdp += IDPF_VPMD_DESCS_PER_LOOP,
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/idpf: fix comma operator warning
2026-03-12 16:43 [PATCH] net/idpf: fix comma operator warning Stephen Hemminger
@ 2026-03-12 16:57 ` Bruce Richardson
2026-03-25 22:53 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2026-03-12 16:57 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Praveen Shetty, Shaiq Wani
On Thu, Mar 12, 2026 at 09:43:44AM -0700, Stephen Hemminger wrote:
> Fix comma operator misuse warnings with clang compiler in idpf that
> was missed in previous change. Shows up when -Wcomma enabled.
>
> Fixes: 57560a92167a ("net/idpf: add AVX2 Tx path for split queue config")
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Yep, this was missed because the previous commit [1] was on your tree but
not applied to main, so missing in mine. :-(
[1] https://patches.dpdk.org/project/dpdk/patch/20260219152302.2103018-1-bruce.richardson@intel.com/
> drivers/net/intel/idpf/idpf_common_rxtx_avx2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> index 4e1062f22d..db7728afad 100644
> --- a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> +++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> @@ -842,7 +842,7 @@ idpf_splitq_vtx_avx2(struct idpf_flex_tx_sched_desc *txdp,
> /* align if needed */
> if (((uintptr_t)txdp & 0x1F) != 0 && nb_pkts != 0) {
> idpf_splitq_vtx1_avx2(txdp, *pkt, flags);
> - txdp++, pkt++, nb_pkts--;
> + txdp++; pkt++; nb_pkts--;
> }
>
> for (; nb_pkts >= IDPF_VPMD_DESCS_PER_LOOP; txdp += IDPF_VPMD_DESCS_PER_LOOP,
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/idpf: fix comma operator warning
2026-03-12 16:57 ` Bruce Richardson
@ 2026-03-25 22:53 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2026-03-25 22:53 UTC (permalink / raw)
To: Stephen Hemminger, Bruce Richardson; +Cc: dev, Praveen Shetty, Shaiq Wani
12/03/2026 17:57, Bruce Richardson:
> On Thu, Mar 12, 2026 at 09:43:44AM -0700, Stephen Hemminger wrote:
> > Fix comma operator misuse warnings with clang compiler in idpf that
> > was missed in previous change. Shows up when -Wcomma enabled.
> >
> > Fixes: 57560a92167a ("net/idpf: add AVX2 Tx path for split queue config")
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Yep, this was missed because the previous commit [1] was on your tree but
> not applied to main, so missing in mine. :-(
Sorry I missed this patch and did a similar one:
https://git.dpdk.org/dpdk/commit/?id=b3b8301dee7f1fd3e6bc8c2d79fd6f6cc04a7d58
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-25 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-12 16:43 [PATCH] net/idpf: fix comma operator warning Stephen Hemminger
2026-03-12 16:57 ` Bruce Richardson
2026-03-25 22:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox