From: KAVYA AV <kavyax.a.v@intel.com>
To: dev@dpdk.org, bruce.richardson@intel.com,
aman.deep.singh@intel.com, vladimir.medvedkin@intel.com
Cc: shaiq.wani@intel.com, KAVYA AV <kavyax.a.v@intel.com>, stable@dpdk.org
Subject: [PATCH] app/testpmd: fix DCB queue allocation for VMDq devices
Date: Fri, 13 Mar 2026 10:15:53 +0000 [thread overview]
Message-ID: <20260313101553.1827216-1-kavyax.a.v@intel.com> (raw)
When using DCB mode with VT disabled and requesting more queues than
traffic classes (e.g., rxq=64 with 8 TCs), testpmd crashes with null
pointer errors because it artificially limits queue allocation to
num_tcs.
For VMDq devices, use device-specific queue count (nb_rx_queues/
nb_tx_queues) instead of limiting to num_tcs. This allows VMDq devices
to utilize their full queue capacity while maintaining compatibility
with non VMDq devices.
Fixes null pointer dereference when queue structures are accessed
beyond the allocated range.
Fixes: 2169699b15fc ("app/testpmd: add queue restriction in DCB command")
Cc: stable@dpdk.org
Signed-off-by: KAVYA AV <kavyax.a.v@intel.com>
---
app/test-pmd/testpmd.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index fbacee89ea..70be52d36f 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -4444,9 +4444,11 @@ init_port_dcb_config(portid_t pid,
if (rte_port->dev_info.vmdq_pool_base == 0) {
nb_rxq = rte_port->dev_info.max_rx_queues;
nb_txq = rte_port->dev_info.max_tx_queues;
- } else {
- nb_rxq = (queueid_t)num_tcs;
- nb_txq = (queueid_t)num_tcs;
+ }
+ /* Use device queue count to prevent null pointer errors */
+ else {
+ nb_rxq = rte_port->dev_info.nb_rx_queues;
+ nb_txq = rte_port->dev_info.nb_tx_queues;
}
}
}
--
2.43.0
next reply other threads:[~2026-03-13 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:15 KAVYA AV [this message]
2026-03-13 21:00 ` [PATCH] app/testpmd: fix DCB queue allocation for VMDq devices Stephen Hemminger
2026-03-16 5:52 ` [PATCH v2] " KAVYA AV
2026-03-23 23:51 ` Stephen Hemminger
2026-03-24 10:05 ` [PATCH v3] " KAVYA AV
2026-03-24 15:46 ` Stephen Hemminger
2026-03-26 11:22 ` A V, KavyaX
2026-04-09 6:43 ` [PATCH v4] " KAVYA AV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313101553.1827216-1-kavyax.a.v@intel.com \
--to=kavyax.a.v@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox