[PATCH] fib: fix name of main TRIE instance memory region

[PATCH] fib: fix name of main TRIE instance memory region

[Andrew Rybchenko]

mem_name was built, but not used when memory is allocated.

Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6")
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
 lib/fib/trie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fib/trie.c b/lib/fib/trie.c
index fa5d9ec6b0..cd61446dd3 100644
--- a/lib/fib/trie.c
+++ b/lib/fib/trie.c
@@ -678,7 +678,7 @@ trie_create(const char *name, int socket_id,
 	num_tbl8 = conf->trie.num_tbl8;
 
 	snprintf(mem_name, sizeof(mem_name), "DP_%s", name);
-	dp = rte_zmalloc_socket(name, sizeof(struct rte_trie_tbl) +
+	dp = rte_zmalloc_socket(mem_name, sizeof(struct rte_trie_tbl) +
 		TRIE_TBL24_NUM_ENT * (1 << nh_sz) + sizeof(uint32_t),
 		RTE_CACHE_LINE_SIZE, socket_id);
 	if (dp == NULL) {
-- 
2.47.3

Re: [PATCH] fib: fix name of main TRIE instance memory region

[Stephen Hemminger]

On Mon, 16 Mar 2026 16:05:18 +0300
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:

> mem_name was built, but not used when memory is allocated.
> 
> Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6")
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---

Ok but the name argument is only used for tracing.
It can just be NULL

Re: [PATCH] fib: fix name of main TRIE instance memory region

[Andrew Rybchenko]

On 3/16/26 6:30 PM, Stephen Hemminger wrote:
> On Mon, 16 Mar 2026 16:05:18 +0300
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
> 
>> mem_name was built, but not used when memory is allocated.
>>
>> Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6")
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> ---
> 
> Ok but the name argument is only used for tracing.
> It can just be NULL

Yes, I know. IMHO the consistency is the main issue here.
It is simply wrong to prepare mem_name and do not use it.
Obviously the second option is use delete above snprintf(),
but I try to follow the author idea as I understand it.