public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"xavier.guillaume@ovhcloud.com" <xavier.guillaume@ovhcloud.com>
Subject: Re: [PATCH v2] net/af_packet: add multi-segment mbuf support for jumbo frames
Date: Mon, 16 Mar 2026 09:02:03 -0700	[thread overview]
Message-ID: <20260316090203.0e138d6f@phoenix.local> (raw)
In-Reply-To: <PA4PR07MB7280BF2BBE65E375F5A95FBE9046A@PA4PR07MB7280.eurprd07.prod.outlook.com>

On Tue, 10 Mar 2026 20:02:49 +0000
Sriram Yagnaraman <sriram.yagnaraman@ericsson.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Tuesday, 10 March 2026 15:03
> > To: Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>
> > Cc: dev@dpdk.org; xavier.guillaume@ovhcloud.com
> > Subject: Re: [PATCH v2] net/af_packet: add multi-segment mbuf support for
> > jumbo frames
> > 
> > On Mon, 9 Mar 2026 22:02:10 +0100
> > Sriram Yagnaraman <sriram.yagnaraman@ericsson.com> wrote:
> >   
> > > Enable jumbo frame reception with default mbuf data room size by
> > > chaining multiple mbufs when packet exceeds single mbuf tailroom.
> > >
> > > The RX path now:
> > > - Copies first segment up to mbuf tailroom
> > > - Allocates and chains additional segments for remaining data
> > > - Properly maintains nb_segs, next pointers, and pkt_len
> > > - Silently drops packets on mbuf allocation failure
> > >
> > > This allows receiving 9KB jumbo frames using standard 2KB mbufs,
> > > chaining ~5 segments per jumbo packet. No need for custom mbuf pools
> > > with large data room.
> > >
> > > Advertises RTE_ETH_RX_OFFLOAD_SCATTER capability.
> > >
> > > Depends-on: series-34567 ("net/af_packet: fix MTU handling and add
> > > jumbo frame support")
> > >
> > > Note: Implementation generated with AI assistance.
> > >
> > > Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>  
> > 
> > Using AI patch review finds several issues.  
> 
> Thanks for the review, I will fix them in v3.
> Perhaps, I will wait for Xavier's changes to be in main before posting the next version.
> 

You can use next-net for-main as baseline. But wait until that gets merged before resubmitting.

  reply	other threads:[~2026-03-16 16:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  9:20 [PATCH v1 0/3] net/af_packet: fix MTU handling and add jumbo frame support Xavier Guillaume
2026-03-06  9:20 ` [PATCH v1 1/3] net/af_packet: fix MTU set data size calculation Xavier Guillaume
2026-03-06  9:20 ` [PATCH v1 2/3] net/af_packet: fix receive buffer overflow Xavier Guillaume
2026-03-06  9:20 ` [PATCH v1 3/3] net/af_packet: support jumbo frames Xavier Guillaume
2026-03-09 16:03   ` Stephen Hemminger
2026-03-09 16:10 ` [PATCH v2 0/3] net/af_packet: fix MTU handling and add jumbo frame support Xavier Guillaume
2026-03-09 16:10   ` [PATCH v2 1/3] net/af_packet: fix MTU set data size calculation Xavier Guillaume
2026-03-09 16:10   ` [PATCH v2 2/3] net/af_packet: fix receive buffer overflow Xavier Guillaume
2026-03-09 16:10   ` [PATCH v2 3/3] net/af_packet: support jumbo frames Xavier Guillaume
2026-03-10 23:31     ` Stephen Hemminger
2026-03-12 13:32       ` Xavier Guillaume
2026-03-12 16:20         ` Stephen Hemminger
2026-03-09 20:16   ` [PATCH v2 0/3] net/af_packet: fix MTU handling and add jumbo frame support Stephen Hemminger
2026-03-09 20:49   ` [PATCH] net/af_packet: add multi-segment mbuf support for jumbo frames Sriram Yagnaraman
2026-03-09 21:02     ` [PATCH v2] " Sriram Yagnaraman
2026-03-10 14:02       ` Stephen Hemminger
2026-03-10 20:02         ` Sriram Yagnaraman
2026-03-16 16:02           ` Stephen Hemminger [this message]
2026-03-19  9:25             ` Sriram Yagnaraman
2026-03-10  1:55   ` [PATCH v2 0/3] net/af_packet: fix MTU handling and add jumbo frame support Stephen Hemminger
2026-03-10 11:21   ` [PATCH v3 " Xavier Guillaume
2026-03-10 11:21     ` [PATCH v3 1/3] net/af_packet: fix MTU set data size calculation Xavier Guillaume
2026-03-10 11:21     ` [PATCH v3 2/3] net/af_packet: fix receive buffer overflow Xavier Guillaume
2026-03-10 11:21     ` [PATCH v3 3/3] net/af_packet: support jumbo frames Xavier Guillaume
2026-03-11 16:03     ` [PATCH v3 0/3] net/af_packet: fix MTU handling and add jumbo frame support Stephen Hemminger
2026-03-12 18:46     ` Stephen Hemminger
2026-03-16 15:59     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316090203.0e138d6f@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=sriram.yagnaraman@ericsson.com \
    --cc=xavier.guillaume@ovhcloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox