Re: [PATCH v7 7/7] net/hinic3: use different callback func to support htn fdir

Stephen Hemminger
2026-03-23T19:50:56Z

On Mon, 23 Mar 2026 16:04:50 +0800
Feifei Wang <wff_light@vip.163.com> wrote:

>
> + if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) {
> + rss_type.ipv6_ext = (rss_hf & RTE_ETH_RSS_IPV6_EX) ? 1 : 0;
> + rss_type.tcp_ipv6_ext = (rss_hf & RTE_ETH_RSS_IPV6_TCP_EX) ? 1 : 0;
> + } else {
> + rss_type.ipv6_ext = 0;
> + rss_type.ipv6_ext = 0;
> + }
> +

Overall AI review is good, but:

One issue remains from V6:
Patch 7/7: net/hinic3: use different callback func to support htn fdir
The copy-paste bug in hinic3_init_rss_type() is still present.
The hinic3_rss_hash_update() instance was fixed but
hinic3_init_rss_type() still has:

rss_type.ipv6_ext = 0;
rss_type.ipv6_ext = 0;

The second line should be rss_type.tcp_ipv6_ext = 0.
This was reported in both the V2 and V6 reviews.