From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, <probb@iol.unh.edu>, <david.marchand@redhat.com>,
<stable@dpdk.org>
Subject: Re: [PATCH 3/7] test/pdump: skip test on FreeBSD
Date: Sat, 21 Mar 2026 09:14:18 -0700 [thread overview]
Message-ID: <20260321091418.74534cc6@phoenix.local> (raw)
In-Reply-To: <abwva7QN2pBRD4Jz@bricha3-mobl1.ger.corp.intel.com>
On Thu, 19 Mar 2026 17:16:27 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:
> On Thu, Mar 19, 2026 at 05:11:37PM +0000, Bruce Richardson wrote:
> > FreeBSD doesn't support multiprocess so skip the pdump unit test which
> > requires multi-process support.
> >
> > Bugzilla ID: 761 (partial fix)
> > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > app/test/test_pdump.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/app/test/test_pdump.c b/app/test/test_pdump.c
> > index 824caef2d4..9d1175b4b0 100644
> > --- a/app/test/test_pdump.c
> > +++ b/app/test/test_pdump.c
> > @@ -5,6 +5,7 @@
> > #include <unistd.h>
> > #include <stdint.h>
> > #include <limits.h>
> > +#include <sys/utsname.h>
> >
> > #include <ethdev_driver.h>
> > #include <rte_pdump.h>
> > @@ -197,7 +198,12 @@ run_pdump_server_tests(void)
> > int
> > test_pdump(void)
> > {
> > + struct utsname name;
> > int ret = 0;
> > +
> > + if (uname(&name) < 0 || strcmp(name.sysname, "FreeBSD") == 0)
> > + return TEST_SKIPPED;
> > +
>
> Self-NAK, I forgot to update this patch to just use
> "RTE_EXEC_ENV_IS_FREEBSD" instead of calling "uname". Will fix in V2.
>
> > if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> > printf("IN PRIMARY PROCESS\n");
> > ret = run_pdump_server_tests();
> > --
> > 2.51.0
> >
Couldn't there be a common dependency in meson.build
would rather not build tests for platforms that are missing the
secondary_process support.
next prev parent reply other threads:[~2026-03-21 16:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 17:11 [PATCH 0/7] Get fast-test suite to run on FreeBSD Bruce Richardson
2026-03-19 17:11 ` [PATCH 1/7] test/timer_secondary: skip test " Bruce Richardson
2026-03-20 14:03 ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 2/7] test/eal_flags: " Bruce Richardson
2026-03-20 14:02 ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 3/7] test/pdump: " Bruce Richardson
2026-03-19 17:16 ` Bruce Richardson
2026-03-21 16:14 ` Stephen Hemminger [this message]
2026-03-23 9:07 ` Bruce Richardson
2026-03-19 17:11 ` [PATCH 4/7] test/secondary_process: " Bruce Richardson
2026-03-20 14:02 ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 5/7] test/external_memory: " Bruce Richardson
2026-03-20 14:01 ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 6/7] test/interrupts: " Bruce Richardson
2026-03-20 14:01 ` Burakov, Anatoly
2026-03-19 17:11 ` [PATCH 7/7] test/debug: fix unit " Bruce Richardson
2026-03-20 14:00 ` Burakov, Anatoly
2026-03-20 14:02 ` David Marchand
2026-03-20 14:18 ` Bruce Richardson
2026-03-19 20:15 ` [PATCH 0/7] Get fast-test suite to run " Patrick Robb
2026-03-19 20:44 ` Patrick Robb
2026-03-20 8:33 ` Bruce Richardson
2026-03-20 14:25 ` David Marchand
2026-03-20 14:31 ` Bruce Richardson
2026-03-20 16:11 ` [PATCH v2 0/2] " Bruce Richardson
2026-03-20 16:11 ` [PATCH v2 1/2] test: fix failing tests " Bruce Richardson
2026-03-25 22:48 ` Thomas Monjalon
2026-03-20 16:11 ` [PATCH v2 2/2] test: simplify spawning extra test processes Bruce Richardson
2026-03-25 22:50 ` Thomas Monjalon
2026-03-24 16:31 ` [PATCH v2 0/2] Get fast-test suite to run on FreeBSD Adam Hassick
2026-04-08 17:44 ` [PATCH v3 " Bruce Richardson
2026-04-08 17:44 ` [PATCH v3 1/2] test: fix failing tests " Bruce Richardson
2026-04-08 17:44 ` [PATCH v3 2/2] test: simplify spawning extra test processes Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260321091418.74534cc6@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=probb@iol.unh.edu \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox