public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Shani Peretz <shperetz@nvidia.com>
To: <dev@dpdk.org>
Cc: <rasland@nvidia.com>, Shani Peretz <shperetz@nvidia.com>,
	<stable@dpdk.org>,
	Wathsala Vithanage <wathsala.vithanage@arm.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>
Subject: [PATCH 2/2] config/arm: revert forced crypto extension for Cortex-A78AE
Date: Sun, 22 Mar 2026 12:24:59 +0200	[thread overview]
Message-ID: <20260322102459.141958-3-shperetz@nvidia.com> (raw)
In-Reply-To: <20260322102459.141958-1-shperetz@nvidia.com>

Revert commit 6e6cc1dc3548
("config/arm: support crypto with Cortex-A78AE").

The change introduced an explicit crypto march extension as a workaround
for an infinite loop in crypto performance tests. The root cause was a
doorbell race due to compiler instruction reordering, now fixed by commit
0986acdceab5 ("common/mlx5: fix doorbell race from compiler reordering").
With the root cause addressed, the workaround is no longer needed.

Additionally, the explicit crypto march extension causes compilation
failures on setups where the toolchain or environment does not support
AES instructions.

Fixes: 6e6cc1dc3548 ("config/arm: support crypto with Cortex-A78AE")
Cc: stable@dpdk.org

Signed-off-by: Shani Peretz <shperetz@nvidia.com>
---
 config/arm/meson.build | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 523b0fc0ed..c2e5f1bce6 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -83,7 +83,8 @@ part_number_config_arm = {
         ]
     },
     '0xd42': {
-        'mcpu' : 'mcpu_cortex-a78ae',
+        'march': 'armv8.4-a',
+        'mcpu' : 'cortex-a78ae',
         'flags': [
             ['RTE_MAX_LCORE', 16],
             ['RTE_MAX_NUMA_NODES', 1]
@@ -704,10 +705,6 @@ mcpu_defs = {
         'march': 'armv8-a',
         'march_extensions': ['crc']
     },
-    'mcpu_cortex-a78ae': {
-        'march': 'armv8.4-a',
-        'march_extensions': ['crypto']
-    },
     'mcpu_ft2000plus': {
         'march': 'armv8-a',
         'march_extensions': ['crc']
-- 
2.34.1


      parent reply	other threads:[~2026-03-22 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-22 10:24 [PATCH 0/2] Fix a doorbell race on Cortex-A78AE Shani Peretz
2026-03-22 10:24 ` [PATCH 1/2] common/mlx5: fix doorbell race from compiler reordering Shani Peretz
2026-03-22 10:24 ` Shani Peretz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260322102459.141958-3-shperetz@nvidia.com \
    --to=shperetz@nvidia.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=wathsala.vithanage@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox