From: Stephen Hemminger <stephen@networkplumber.org>
To: Feifei Wang <wff_light@vip.163.com>
Cc: dev@dpdk.org, Feifei Wang <wangfeifei40@huawei.com>
Subject: Re: [PATCH v7 7/7] net/hinic3: use different callback func to support htn fdir
Date: Mon, 23 Mar 2026 12:50:49 -0700 [thread overview]
Message-ID: <20260323125049.1ae8d1bb@phoenix.local> (raw)
In-Reply-To: <20260323080455.2699-8-wff_light@vip.163.com>
On Mon, 23 Mar 2026 16:04:50 +0800
Feifei Wang <wff_light@vip.163.com> wrote:
>
> + if (nic_dev->feature_cap & NIC_F_HTN_CMDQ) {
> + rss_type.ipv6_ext = (rss_hf & RTE_ETH_RSS_IPV6_EX) ? 1 : 0;
> + rss_type.tcp_ipv6_ext = (rss_hf & RTE_ETH_RSS_IPV6_TCP_EX) ? 1 : 0;
> + } else {
> + rss_type.ipv6_ext = 0;
> + rss_type.ipv6_ext = 0;
> + }
> +
Overall AI review is good, but:
One issue remains from V6:
Patch 7/7: net/hinic3: use different callback func to support htn fdir
The copy-paste bug in hinic3_init_rss_type() is still present.
The hinic3_rss_hash_update() instance was fixed but
hinic3_init_rss_type() still has:
rss_type.ipv6_ext = 0;
rss_type.ipv6_ext = 0;
The second line should be rss_type.tcp_ipv6_ext = 0.
This was reported in both the V2 and V6 reviews.
next prev parent reply other threads:[~2026-03-23 19:50 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 10:05 [PATCH 0/7] hinic3 change for support new SPx NIC Feifei Wang
2026-01-31 10:05 ` [PATCH 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-16 13:43 ` [V2 0/7] hinic3 change for support new SPx NIC Feifei Wang
2026-03-16 13:43 ` [V2 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-16 13:43 ` [V2 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-16 13:43 ` [V2 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-16 13:43 ` [V2 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-16 13:43 ` [V2 5/7] net/hinic3: add rx " Feifei Wang
2026-03-16 13:43 ` [V2 6/7] net/hinic3: add tx " Feifei Wang
2026-03-16 13:43 ` [V2 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-03-16 15:45 ` [V2 0/7] hinic3 change for support new SPx NIC Stephen Hemminger
2026-03-19 2:50 ` 回复: " wangfeifei (J)
2026-03-19 13:52 ` [v6 " Feifei Wang
2026-03-19 13:52 ` [V6 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-19 13:52 ` [V6 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-19 13:52 ` [V6 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-19 13:52 ` [V6 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-19 13:52 ` [V6 5/7] net/hinic3: add rx " Feifei Wang
2026-03-19 13:52 ` [V6 6/7] net/hinic3: add tx " Feifei Wang
2026-03-19 13:52 ` [V6 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-03-21 17:32 ` [v6 0/7] hinic3 change for support new SPx NIC Stephen Hemminger
2026-03-22 16:32 ` Stephen Hemminger
2026-03-23 8:04 ` [PATCH v7 " Feifei Wang
2026-03-23 8:04 ` [PATCH v7 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-23 19:51 ` Stephen Hemminger
2026-03-23 8:04 ` [PATCH v7 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-23 8:04 ` [PATCH v7 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-23 8:04 ` [PATCH v7 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-23 8:04 ` [PATCH v7 5/7] net/hinic3: add rx " Feifei Wang
2026-03-23 8:04 ` [PATCH v7 6/7] net/hinic3: add tx " Feifei Wang
2026-03-23 8:04 ` [PATCH v7 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-03-23 19:50 ` Stephen Hemminger [this message]
2026-03-24 1:19 ` 回复: " wangfeifei (J)
2026-03-24 1:55 ` [PATCH v8 0/7] hinic3 change for support new SPx NIC Feifei Wang
2026-03-24 1:55 ` [PATCH v8 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-24 1:55 ` [PATCH v8 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-24 1:55 ` [PATCH v8 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-24 1:55 ` [PATCH v8 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-24 1:55 ` [PATCH v8 5/7] net/hinic3: add rx " Feifei Wang
2026-03-24 1:55 ` [PATCH v8 6/7] net/hinic3: add tx " Feifei Wang
2026-03-24 1:55 ` [PATCH v8 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-03-24 3:27 ` [PATCH v8 0/7] hinic3 change for support new SPx NIC Stephen Hemminger
2026-03-24 3:31 ` Stephen Hemminger
2026-03-24 14:41 ` Stephen Hemminger
2026-03-24 14:42 ` Stephen Hemminger
2026-03-25 1:30 ` 回复: " wangfeifei (J)
2026-03-25 13:37 ` Thomas Monjalon
2026-03-25 14:02 ` Thomas Monjalon
2026-03-18 2:19 ` [v3 " Feifei Wang
2026-03-18 2:19 ` [V3 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-18 2:19 ` [V3 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-18 2:19 ` [V3 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-18 2:19 ` [V3 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-18 2:19 ` [V3 5/7] net/hinic3: add rx " Feifei Wang
2026-03-18 2:19 ` [V3 6/7] net/hinic3: add tx " Feifei Wang
2026-03-18 2:19 ` [V3 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-03-18 6:20 ` [v4 0/7] hinic3 change for support new SPx NIC Feifei Wang
2026-03-18 6:20 ` [V4 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-18 6:20 ` [V4 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-18 6:20 ` [V4 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-18 6:20 ` [V4 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-18 6:20 ` [V4 5/7] net/hinic3: add rx " Feifei Wang
2026-03-18 6:20 ` [V4 6/7] net/hinic3: add tx " Feifei Wang
2026-03-18 6:20 ` [V4 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-03-18 12:31 ` [v5 0/7] hinic3 change for support new SPx NIC Feifei Wang
2026-03-18 12:31 ` [V5 1/7] net/hinic3: add support for new SPx series NIC Feifei Wang
2026-03-18 12:31 ` [V5 2/7] net/hinic3: add enhance cmdq " Feifei Wang
2026-03-18 12:31 ` [V5 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-03-18 12:31 ` [V5 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-03-18 12:32 ` [V5 5/7] net/hinic3: add rx " Feifei Wang
2026-03-18 12:32 ` [V5 6/7] net/hinic3: add tx " Feifei Wang
2026-03-18 12:32 ` [V5 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-01-31 10:05 ` [PATCH 2/7] net/hinic3: add enhance cmdq support for new SPx series NIC Feifei Wang
2026-01-31 10:05 ` [PATCH 3/7] net/hinic3: use different callback func to split new/old cmdq operations Feifei Wang
2026-01-31 10:06 ` [PATCH 4/7] net/hinic3: add fun init ops to support Compact CQE Feifei Wang
2026-01-31 10:06 ` [PATCH 5/7] net/hinic3: add rx " Feifei Wang
2026-01-31 10:06 ` [PATCH 6/7] net/hinic3: add tx " Feifei Wang
2026-01-31 10:06 ` [PATCH 7/7] net/hinic3: use different callback func to support htn fdir Feifei Wang
2026-01-31 18:17 ` [REVIEW] net/hinic3: use different callback func to support htnfdir Stephen Hemminger
2026-02-02 1:17 ` 回复: " wangfeifei (J)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323125049.1ae8d1bb@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wangfeifei40@huawei.com \
--cc=wff_light@vip.163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox