public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Talluri Chaitanyababu <chaitanyababux.talluri@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	fengchengwen@huawei.com, aman.deep.singh@intel.com,
	shaiq.wani@intel.com, stable@dpdk.org
Subject: Re: [PATCH v5] app/testpmd: fix DCB forwarding TC mismatch handling
Date: Mon, 23 Mar 2026 17:06:50 -0700	[thread overview]
Message-ID: <20260323170650.1a6f24f3@phoenix.local> (raw)
In-Reply-To: <20260320062954.2042887-1-chaitanyababux.talluri@intel.com>

On Fri, 20 Mar 2026 06:29:54 +0000
Talluri Chaitanyababu <chaitanyababux.talluri@intel.com> wrote:

> Fix DCB forwarding failed when the number of TCs on ports is inconsistent.
> 
> When ports have asymmetric TC configurations (e.g. 2 ports, port0 has
> 4 TCs and port1 has 8 TCs), the forwarding logic iterates based only
> on the Rx port TC count.
> This can lead to accessing invalid Tx TC entries and incorrect queue
> mapping, which will result in a SIGFPE exception.
> 
> Additionally, the existing VMDq pool guard in dcb_fwd_config_setup()
> only checks RX queue counts and does not consider the case where the TX
> port has no queues for a given pool/TC combination.
> 
> Fix this by:
> 1. Introducing an effective TC count using RTE_MIN() of Rx and Tx TC
>    values, ensuring forwarding only operates on valid TCs supported by
>    both ports.
> 2. Updating the loop condition to use the effective TC count instead of
>    only the Rx TC count.
> 3. Extending the queue validation in dcb_fwd_config_setup() to ensure
>    both Rx and Tx queues are valid for a given TC.
> 
> Testpmd command to reproduce:
> 
> x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1-20 -n 4 \
> -a 0000:31:00.0 -a 0000:4b:00.0 \
> --file-prefix=testpmd1 -- -i --rxq=256 --txq=256 \
> --nb-cores=16 --total-num-mbufs=600000
> 
> port stop all
> port config 0 dcb vt off 8 pfc on
> port config 1 dcb vt off 8 pfc on
> port start all
> port stop all
> port config 0 dcb vt off 4 pfc on
> 
> This ensures correct queue mapping and avoids issues when switching
> between different DCB configurations across ports.
> 
> Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Talluri Chaitanyababu <chaitanyababux.talluri@intel.com>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---

Applied to next-net

      parent reply	other threads:[~2026-03-24  0:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  8:37 [PATCH] app/testpmd: fix DCB forwarding TC mask and queue guard Talluri Chaitanyababu
2026-03-11 15:56 ` Stephen Hemminger
2026-03-12 10:36 ` [PATCH v2] " Talluri Chaitanyababu
2026-03-12 18:44   ` Stephen Hemminger
2026-03-13  0:19   ` fengchengwen
2026-03-16  6:05     ` Talluri, ChaitanyababuX
2026-03-17  1:07       ` fengchengwen
2026-03-18  7:21         ` Talluri, ChaitanyababuX
2026-03-19  1:19           ` fengchengwen
2026-03-16  6:21 ` [PATCH v3] " Talluri Chaitanyababu
2026-03-17  1:23   ` fengchengwen
2026-03-17  8:57   ` Thomas Monjalon
2026-03-17  9:02     ` Thomas Monjalon
2026-03-18  6:17 ` [PATCH v4] app/testpmd: fix DCB forwarding TC mismatch handling Talluri Chaitanyababu
2026-03-19  1:35   ` fengchengwen
2026-03-20  6:29 ` [PATCH v5] " Talluri Chaitanyababu
2026-03-20  9:38   ` fengchengwen
2026-03-24  0:06   ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260323170650.1a6f24f3@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=aman.deep.singh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chaitanyababux.talluri@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=shaiq.wani@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox