From: Patrick Robb <probb@iol.unh.edu>
To: luca.vizzarro@arm.com
Cc: dev@dpdk.org, abailey@iol.unh.edu, dmarx@iol.unh.edu,
Patrick Robb <probb@iol.unh.edu>
Subject: [PATCH v3 1/2] dts: always use ethdev ports to check capabilities
Date: Mon, 23 Mar 2026 20:52:40 -0400 [thread overview]
Message-ID: <20260324005241.761124-1-probb@iol.unh.edu> (raw)
In-Reply-To: <20260323180818.674041-1-probb@iol.unh.edu>
DTS uses its capability check step to query ethdev devices for
their capabilities, and then run or skip testsuites according
to their respective capability requirements. So, we should be
running the capability check step with the ethernet devices
in all cases. However, when crypto ports are specified, a
crypto virtual function will be used in the capability check
step in error. So, this patch changes the default behavior
when computing EAL arguments, setting the port allow list to
the ethernet devices by default. In addition, as a defensive
coding measure, the capability check now specifies its usage
of the SUT ethernet devices when acquiring capabilities.
Fixes: 76e3fdd7b5c6 ("dts: add cryptodev package to DTS")
Signed-off-by: Patrick Robb <probb@iol.unh.edu>
Reviewed-by: Andrew Bailey <abailey@iol.unh.edu>
Tested-by: Andrew Bailey <abailey@iol.unh.edu>
---
dts/framework/remote_session/dpdk_shell.py | 5 +----
dts/framework/testbed_model/capability.py | 2 +-
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/dts/framework/remote_session/dpdk_shell.py b/dts/framework/remote_session/dpdk_shell.py
index b94d336d4e..51b97d4ff6 100644
--- a/dts/framework/remote_session/dpdk_shell.py
+++ b/dts/framework/remote_session/dpdk_shell.py
@@ -46,10 +46,7 @@ def compute_eal_params(
params.prefix = prefix
if params.allowed_ports is None:
- if ctx.topology.crypto_vf_ports:
- params.allowed_ports = [ctx.topology.crypto_vf_ports[0]]
- else:
- params.allowed_ports = ctx.topology.sut_dpdk_ports
+ params.allowed_ports = ctx.topology.sut_dpdk_ports
return params
diff --git a/dts/framework/testbed_model/capability.py b/dts/framework/testbed_model/capability.py
index b166014e0c..960370fc72 100644
--- a/dts/framework/testbed_model/capability.py
+++ b/dts/framework/testbed_model/capability.py
@@ -384,7 +384,7 @@ def get_supported_capabilities(
)
if cls.capabilities_to_check:
capabilities_to_check_map = cls._get_decorated_capabilities_map()
- with TestPmd() as testpmd:
+ with TestPmd(allowed_ports=topology.sut_dpdk_ports) as testpmd:
for (
conditional_capability_fn,
capabilities,
--
2.49.0
next prev parent reply other threads:[~2026-03-24 0:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 18:08 [PATCH v1 0/2] dts: dpdk shell bug fixes Patrick Robb
2026-03-23 18:08 ` [PATCH v1 1/2] dts: always use ethdev ports to check capabilities Patrick Robb
2026-03-23 19:14 ` Andrew Bailey
2026-03-23 18:08 ` [PATCH v1 2/2] dts: avoid dpdk resources conflict Patrick Robb
2026-03-23 19:15 ` Andrew Bailey
2026-03-23 19:24 ` Andrew Bailey
2026-03-23 20:20 ` [PATCH v2 0/2] dts: dpdk shell bug fixes Patrick Robb
2026-03-23 20:20 ` [PATCH v2 1/2] dts: always use ethdev ports to check capabilities Patrick Robb
2026-03-23 20:20 ` [PATCH v2 2/2] dts: avoid dpdk resources conflict Patrick Robb
2026-03-24 0:52 ` Patrick Robb [this message]
2026-03-24 0:52 ` [PATCH v3 " Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324005241.761124-1-probb@iol.unh.edu \
--to=probb@iol.unh.edu \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox