Re: [PATCH] app/testpmd: fix memory leak in port flow configure

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 24 Mar 2026 10:10:44 +0200
Shani Peretz <shperetz@nvidia.com> wrote:

> When "flow configure" is issued multiple times on the same port,
> port_flow_configure() allocates a new job_list via calloc() without
> freeing the previous allocation, leaking it. The old pointer is
> simply overwritten.
> 
>   testpmd> flow configure 0 queues_number 10 queues_size 256 ...
>   testpmd> flow configure 0 queues_number 10 queues_size 256 ...  
> 
> The patch fixes this by freeing the existing job_list before allocating
> the replacement.
> 
> Fixes: df503d757b36 ("app/testpmd: fix flow queue job leaks")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> ---
>  app/test-pmd/config.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index f9f3c542a6..f0a784bf2f 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1836,6 +1836,7 @@ port_flow_configure(portid_t port_id,
>  	port->queue_sz = queue_attr->size;
>  	for (std_queue = 0; std_queue < nb_queue; std_queue++)
>  		attr_list[std_queue] = queue_attr;
> +	free(port->job_list);
>  	port->job_list = calloc(nb_queue, sizeof(*port->job_list));

You could use realloc here, but it doesn't matter much