From: Stephen Hemminger <stephen@networkplumber.org>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Aman Singh <aman.deep.singh@intel.com>, <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>,
"Adrian Schollmeyer" <a.schollmeyer@syseleven.de>
Subject: Re: [PATCH 2/2] app/testpmd: revert switch domain mismatch check
Date: Tue, 24 Mar 2026 08:17:05 -0700 [thread overview]
Message-ID: <20260324081705.085e4a9f@phoenix.local> (raw)
In-Reply-To: <20260324123709.3471-3-dsosnowski@nvidia.com>
On Tue, 24 Mar 2026 13:37:09 +0100
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
> This reverts commit 8ebba91086f47c90e398d7775921e05659c0d62f.
>
> Previous patch changed --rxq-share parameter logic.
> If this parameter is passed, then unique share group index
> per switch and Rx domain will be assigned to each shared Rx queue.
> As a result the check for domain mismatch is not needed.
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---
One nit from AI review
Clean revert, correctness is fine — the mismatch check is now redundant
since patch 1 guarantees ports in the same share group have matching
domain/rx_domain by construction.
Warning: Double blank line after deletion. The removal leaves two
consecutive blank lines between the variable declarations (int ret;)
and the if ((rx_pkt_nb_segs > 1) block. One should be removed.
next prev parent reply other threads:[~2026-03-24 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 12:37 [PATCH 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 12:37 ` [PATCH 1/2] " Dariusz Sosnowski
2026-03-24 15:15 ` Stephen Hemminger
2026-03-25 16:45 ` Stephen Hemminger
2026-03-24 12:37 ` [PATCH 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-24 15:17 ` Stephen Hemminger [this message]
2026-03-24 16:56 ` [PATCH v2 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-24 16:56 ` [PATCH v2 1/2] " Dariusz Sosnowski
2026-03-25 16:49 ` Stephen Hemminger
2026-03-25 18:06 ` Dariusz Sosnowski
2026-03-25 16:50 ` Stephen Hemminger
2026-03-25 18:12 ` Dariusz Sosnowski
2026-03-24 16:56 ` [PATCH v2 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 1/2] " Dariusz Sosnowski
2026-03-25 18:51 ` Stephen Hemminger
2026-03-25 19:11 ` Dariusz Sosnowski
2026-03-25 18:02 ` [PATCH v3 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 1/2] " Dariusz Sosnowski
2026-03-25 19:09 ` [PATCH v4 2/2] app/testpmd: revert switch domain mismatch check Dariusz Sosnowski
2026-03-25 20:16 ` [PATCH v4 0/2] app/testpmd: assign share group dynamically Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324081705.085e4a9f@phoenix.local \
--to=stephen@networkplumber.org \
--cc=a.schollmeyer@syseleven.de \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox