[PATCH 10/12] net/pcap: cleanup MAC address handling

Stephen Hemminger
2026-01-06T18:34:16Z

Use rte_ether_addr structure to avoid memcpy and void *.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/pcap/pcap_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index 3eb313ebb8..bf863e8708 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -1383,9 +1383,9 @@ pmd_init_internals(struct rte_vdev_device *vdev,

static int
eth_pcap_update_mac(const char *if_name, struct rte_eth_dev *eth_dev,
- const unsigned int numa_node)
+ const unsigned int numa_node)
{
- void *mac_addrs;
+ struct rte_ether_addr *mac_addrs;
struct rte_ether_addr mac;

if (osdep_iface_mac_get(if_name, &mac) < 0)
@@ -1396,7 +1396,7 @@ eth_pcap_update_mac(const char *if_name, struct rte_eth_dev *eth_dev,
return -1;

PMD_LOG(INFO, "Setting phy MAC for %s", if_name);
- rte_memcpy(mac_addrs, mac.addr_bytes, RTE_ETHER_ADDR_LEN);
+ rte_ether_addr_copy(&mac, mac_addrs);
eth_dev->data->mac_addrs = mac_addrs;
return 0;
}
--
2.51.0