Re: [PATCH v2 1/2] app/testpmd: assign share group dynamically

Stephen Hemminger
2026-03-25T16:51:03Z

On Tue, 24 Mar 2026 17:56:56 +0100
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:

> + /*
> + * testpmd assigns all queues on a given port to single share group.
> + * There are RTE_MAX_ETHPORTS share group slots,
> + * so at least one should always be available.
> + */
> + RTE_ASSERT(first_free < RTE_DIM(share_group_slots));
> +

Since RTE_ASSERT is compiled away in normal builds, this is a noop.
Please use a regular if statement and error handling.