Re: [PATCH 2/2] app/testpmd: revert switch domain mismatch check

Stephen Hemminger
2026-03-24T15:17:13Z

On Tue, 24 Mar 2026 13:37:09 +0100
Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:

> This reverts commit 8ebba91086f47c90e398d7775921e05659c0d62f.
>
> Previous patch changed --rxq-share parameter logic.
> If this parameter is passed, then unique share group index
> per switch and Rx domain will be assigned to each shared Rx queue.
> As a result the check for domain mismatch is not needed.
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> ---

One nit from AI review

Clean revert, correctness is fine — the mismatch check is now redundant
since patch 1 guarantees ports in the same share group have matching
domain/rx_domain by construction.

Warning: Double blank line after deletion. The removal leaves two
consecutive blank lines between the variable declarations (int ret;)
and the if ((rx_pkt_nb_segs > 1) block. One should be removed.