From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9357A106F31D for ; Thu, 26 Mar 2026 10:25:17 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AF9742D2B; Thu, 26 Mar 2026 11:25:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F385042D26 for ; Thu, 26 Mar 2026 11:25:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774520712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QZ8APefGC1oy3Tka3o6UNQU3PGFn7L15g0Ss9n9O6MU=; b=EnGDfocHxVyRRLorIGYOIoAtqt7s5kOErAT/wPb7jv2dMYa4HeBQDFQFVmf9szRpvhIVrN jlgW7Pjlwmb2GbPvxiC12V8KfuifdW5O/1A51tLBmOmtARf3Re9tRAMteoY5YV/gTzh+HO eIdB65nTY768MD0L/FknnqKhe0VuwdY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-lzVl2p4tOPiur2bzLj0_Hg-1; Thu, 26 Mar 2026 06:25:09 -0400 X-MC-Unique: lzVl2p4tOPiur2bzLj0_Hg-1 X-Mimecast-MFC-AGG-ID: lzVl2p4tOPiur2bzLj0_Hg_1774520708 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DA7361944F12; Thu, 26 Mar 2026 10:25:07 +0000 (UTC) Received: from dmarchan.lan (unknown [10.44.33.173]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CF8B51955D84; Thu, 26 Mar 2026 10:25:05 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Bruce Richardson , Kevin Traynor , Hemant Agrawal , Maxime Leroy , Sachin Saxena Subject: [PATCH v2 3/7] drivers/bus: require probe function for NXP drivers Date: Thu, 26 Mar 2026 11:24:19 +0100 Message-ID: <20260326102424.2361945-4-david.marchand@redhat.com> In-Reply-To: <20260326102424.2361945-1-david.marchand@redhat.com> References: <20260323105306.1531689-1-david.marchand@redhat.com> <20260326102424.2361945-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oaMuwY9kL8rJ6-unB_lGVpGLUCd7wI2osoic53nCAho_1774520708 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rather than silently ignore an invalid driver, enforce every registered driver has a probe callback. Signed-off-by: David Marchand Acked-by: Bruce Richardson Acked-by: Kevin Traynor Acked-by: Hemant Agrawal Tested-by: Maxime Leroy --- drivers/bus/dpaa/dpaa_bus.c | 6 +++--- drivers/bus/fslmc/fslmc_bus.c | 7 +------ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index d9830b68ca..5e0f32bfe8 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -614,6 +614,7 @@ void rte_dpaa_driver_register(struct rte_dpaa_driver *driver) { RTE_VERIFY(driver); + RTE_VERIFY(driver->probe != NULL); BUS_INIT_FUNC_TRACE(); @@ -808,9 +809,8 @@ rte_dpaa_bus_probe(void) if (rte_dev_is_probed(&dev->device)) continue; - if (!drv->probe || - (dev->device.devargs && - dev->device.devargs->policy == RTE_DEV_BLOCKED)) + if (dev->device.devargs && + dev->device.devargs->policy == RTE_DEV_BLOCKED) continue; if (probe_all || diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index abdb0ad50d..ac9fb7a08c 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -465,9 +465,6 @@ rte_fslmc_probe(void) if (ret) continue; - if (!drv->probe) - continue; - if (rte_dev_is_probed(&dev->device)) continue; @@ -534,6 +531,7 @@ void rte_fslmc_driver_register(struct rte_dpaa2_driver *driver) { RTE_VERIFY(driver); + RTE_VERIFY(driver->probe != NULL); TAILQ_INSERT_TAIL(&rte_fslmc_bus.driver_list, driver, next); } @@ -601,9 +599,6 @@ fslmc_bus_plug(struct rte_device *rte_dev) if (ret) continue; - if (!drv->probe) - continue; - if (rte_dev_is_probed(&dev->device)) continue; -- 2.53.0