* [PATCH] net/ice/base: fix double HW reinitialization
@ 2026-03-26 18:20 Bruce Richardson
2026-03-27 11:21 ` Loftus, Ciara
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2026-03-26 18:20 UTC (permalink / raw)
To: dev; +Cc: anatoly.burakov, Bruce Richardson, stable
After downloading an alternate scheduler topology, the HW needs to be
reinitialized. Since commit b47c1229d617 ("net/ice/base: improve global
config lock behavior"), a reinitialization is done in the topology
download code itself, so we need to remove the extra initialization from
the calling code.
Fixes: b47c1229d617 ("net/ice/base: improve global config lock behavior")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/ice/base/ice_ddp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/intel/ice/base/ice_ddp.c b/drivers/net/intel/ice/base/ice_ddp.c
index 68e75be4d2..ae80d93656 100644
--- a/drivers/net/intel/ice/base/ice_ddp.c
+++ b/drivers/net/intel/ice/base/ice_ddp.c
@@ -1359,10 +1359,6 @@ enum ice_ddp_state ice_init_pkg(struct ice_hw *hw, u8 *buf, u32 len, bool load_s
res);
return ICE_DDP_PKG_ERR;
}
- ice_debug(hw, ICE_DBG_INIT,
- "Topology download successful, reinitializing device\n");
- ice_deinit_hw(hw);
- ice_init_hw(hw);
}
/* initialize package info */
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] net/ice/base: fix double HW reinitialization
2026-03-26 18:20 [PATCH] net/ice/base: fix double HW reinitialization Bruce Richardson
@ 2026-03-27 11:21 ` Loftus, Ciara
2026-03-27 11:45 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Loftus, Ciara @ 2026-03-27 11:21 UTC (permalink / raw)
To: Richardson, Bruce, dev@dpdk.org
Cc: Burakov, Anatoly, Richardson, Bruce, stable@dpdk.org
> Subject: [PATCH] net/ice/base: fix double HW reinitialization
>
> After downloading an alternate scheduler topology, the HW needs to be
> reinitialized. Since commit b47c1229d617 ("net/ice/base: improve global
> config lock behavior"), a reinitialization is done in the topology
> download code itself, so we need to remove the extra initialization from
> the calling code.
>
> Fixes: b47c1229d617 ("net/ice/base: improve global config lock behavior")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> drivers/net/intel/ice/base/ice_ddp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/intel/ice/base/ice_ddp.c
> b/drivers/net/intel/ice/base/ice_ddp.c
> index 68e75be4d2..ae80d93656 100644
> --- a/drivers/net/intel/ice/base/ice_ddp.c
> +++ b/drivers/net/intel/ice/base/ice_ddp.c
> @@ -1359,10 +1359,6 @@ enum ice_ddp_state ice_init_pkg(struct ice_hw
> *hw, u8 *buf, u32 len, bool load_s
> res);
> return ICE_DDP_PKG_ERR;
> }
> - ice_debug(hw, ICE_DBG_INIT,
> - "Topology download successful, reinitializing
> device\n");
> - ice_deinit_hw(hw);
> - ice_init_hw(hw);
> }
>
> /* initialize package info */
> --
> 2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/ice/base: fix double HW reinitialization
2026-03-27 11:21 ` Loftus, Ciara
@ 2026-03-27 11:45 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2026-03-27 11:45 UTC (permalink / raw)
To: Loftus, Ciara; +Cc: dev@dpdk.org, Burakov, Anatoly, stable@dpdk.org
On Fri, Mar 27, 2026 at 11:21:54AM +0000, Loftus, Ciara wrote:
> > Subject: [PATCH] net/ice/base: fix double HW reinitialization
> >
> > After downloading an alternate scheduler topology, the HW needs to be
> > reinitialized. Since commit b47c1229d617 ("net/ice/base: improve global
> > config lock behavior"), a reinitialization is done in the topology
> > download code itself, so we need to remove the extra initialization from
> > the calling code.
> >
> > Fixes: b47c1229d617 ("net/ice/base: improve global config lock behavior")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
>
Thanks.
Patch applied to dpdk-next-net-intel.
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-26 18:20 [PATCH] net/ice/base: fix double HW reinitialization Bruce Richardson
2026-03-27 11:21 ` Loftus, Ciara
2026-03-27 11:45 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox