public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com>
To: <dev@dpdk.org>
Cc: <Selwin.Sebastian@amd.com>,
	Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com>,
	<stable@dpdk.org>
Subject: [PATCH v1 4/4] net/axgbe: fix SGMII autoneg status bits
Date: Fri, 27 Mar 2026 17:50:06 +0530	[thread overview]
Message-ID: <20260327122011.1534-4-ashokkumar.natarajan@amd.com> (raw)
In-Reply-To: <20260327122011.1534-1-ashokkumar.natarajan@amd.com>

The SGMII autonegotiation status bit definitions do not match the
hardware specification. The link status and duplex bits are defined
at incorrect positions, which can lead to incorrect link state and
duplex reporting.

Correct the SGMII autoneg status bit definitions to align with the
hardware specification.

Fixes: 572890ef6625 ("net/axgbe: add structs for MAC init and reset")
Cc: stable@dpdk.org

Signed-off-by: Ashok Kumar Natarajan <ashokkumar.natarajan@amd.com>
---
 drivers/net/axgbe/axgbe_ethdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h
index 24336f31f6..77c21469a8 100644
--- a/drivers/net/axgbe/axgbe_ethdev.h
+++ b/drivers/net/axgbe/axgbe_ethdev.h
@@ -114,12 +114,12 @@
 #define AXGBE_LINK_TIMEOUT		5
 #define AXGBE_KR_TRAINING_WAIT_ITER	50
 
-#define AXGBE_SGMII_AN_LINK_STATUS	BIT(1)
+#define AXGBE_SGMII_AN_LINK_STATUS	BIT(4)
 #define AXGBE_SGMII_AN_LINK_SPEED	(BIT(2) | BIT(3))
 #define AXGBE_SGMII_AN_LINK_SPEED_10	0x00
 #define AXGBE_SGMII_AN_LINK_SPEED_100	0x04
 #define AXGBE_SGMII_AN_LINK_SPEED_1000	0x08
-#define AXGBE_SGMII_AN_LINK_DUPLEX	BIT(4)
+#define AXGBE_SGMII_AN_LINK_DUPLEX	BIT(1)
 
 /* ECC correctable error notification window (seconds) */
 #define AXGBE_ECC_LIMIT			60
-- 
2.34.1


  parent reply	other threads:[~2026-03-27 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 12:20 [PATCH v1 1/4] net/axgbe: fix MAC TCR speed select field width Ashok Kumar Natarajan
2026-03-27 12:20 ` [PATCH v1 2/4] net/axgbe: add 100 Mbps MAC speed select Ashok Kumar Natarajan
2026-03-27 12:20 ` [PATCH v1 3/4] net/axgbe: fix auto-neg advert/supported defs Ashok Kumar Natarajan
2026-03-27 12:20 ` Ashok Kumar Natarajan [this message]
2026-03-27 16:21 ` [PATCH v1 1/4] net/axgbe: fix MAC TCR speed select field width Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327122011.1534-4-ashokkumar.natarajan@amd.com \
    --to=ashokkumar.natarajan@amd.com \
    --cc=Selwin.Sebastian@amd.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox