Re: [PATCH] power/amd_uncore: add e-smi installation instructions

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 29 Nov 2024 04:32:07 +0000
Sivaprasad Tummala <sivaprasad.tummala@amd.com> wrote:

> Added section for installing and building the E-SMI library
> for AMD EPYC Uncore support and version requirements.
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

A lot has changed since this patch was originally submitted, and
apologies for the long delay in getting back to it. The E-SMI library
is in much better shape now — it's packaged in Fedora and EPEL, v4.2+
bundles the amd_hsmp.h header that was causing build failures, and
upstream now has pkg-config support. 

Please revise the patch (and the meson.build) to match current E-SMI upstream.
The dependency check should use dependency('e_smi', required: false) via pkg-config
rather than the bare cc.find_library() that's there now.
The current ESMI_header variable in the build file is defined but never tested —
that should be cleaned up too. 

For the documentation, just state the minimum E-SMI version required and link to
the upstream project. No need to reproduce build instructions; that's the upstream project's
job, and distro packages make it even easier.

It would be great to get this updated in time for the 26.11 LTS release.