Re: [PATCH v3 39/44] drivers/vdpa: replace use of sys/queue.h

Maxime Coquelin
2025-11-04T09:24:33Z

On Mon, Nov 3, 2025 at 5:53 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Use rte_bsd_queue.h instead.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa.h | 3 ++-
> drivers/vdpa/sfc/sfc_vdpa.c | 2 +-
> drivers/vdpa/sfc/sfc_vdpa.h | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h
> index a398aa22ce..8071e1a5e0 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa.h
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa.h
> @@ -6,7 +6,8 @@
> #define RTE_PMD_MLX5_VDPA_H_
>
> #include <linux/virtio_net.h>
> -#include <sys/queue.h>
> +
> +#include <rte_bsd_queue.h>
>
> #ifdef PEDANTIC
> #pragma GCC diagnostic ignored "-Wpedantic"
> diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c
> index eda111954f..73c75acca2 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa.c
> +++ b/drivers/vdpa/sfc/sfc_vdpa.c
> @@ -5,8 +5,8 @@
> #include <stdbool.h>
> #include <stdint.h>
> #include <pthread.h>
> -#include <sys/queue.h>
>
> +#include <rte_bsd_queue.h>
> #include <rte_common.h>
> #include <rte_devargs.h>
> #include <rte_errno.h>
> diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h
> index 2b843e563d..a240a8be25 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa.h
> +++ b/drivers/vdpa/sfc/sfc_vdpa.h
> @@ -6,8 +6,8 @@
> #define _SFC_VDPA_H
>
> #include <stdint.h>
> -#include <sys/queue.h>
>
> +#include <rte_bsd_queue.h>
> #include <bus_pci_driver.h>
>
> #include "sfc_efx.h"
> --
> 2.51.0
>

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime