Re: [PATCH v2 29/43] net/sfc: replace use of sys/queue.h

Andrew Rybchenko
2025-08-25T06:47:15Z

On 8/25/25 06:38, Stephen Hemminger wrote:
> Replace use of system sys/queue.h with DPDK rte_bsd_queue.h
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/sfc/sfc_dp.c | 2 +-
> drivers/net/sfc/sfc_dp.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/sfc/sfc_dp.c b/drivers/net/sfc/sfc_dp.c
> index 7e2a20e4dc..66ff2ed789 100644
> --- a/drivers/net/sfc/sfc_dp.c
> +++ b/drivers/net/sfc/sfc_dp.c
> @@ -7,7 +7,7 @@
> * for Solarflare) and Solarflare Communications, Inc.
> */
>
> -#include <sys/queue.h>
> +#include <rte_bsd_queue.h>

IMHO it is not nice since headers are grouped and rte headers group is
located below.

> #include <stdalign.h>
> #include <string.h>
> #include <errno.h>
> diff --git a/drivers/net/sfc/sfc_dp.h b/drivers/net/sfc/sfc_dp.h
> index 545f0f32bf..6f61b20a0f 100644
> --- a/drivers/net/sfc/sfc_dp.h
> +++ b/drivers/net/sfc/sfc_dp.h
> @@ -11,7 +11,6 @@
> #define _SFC_DP_H
>
> #include <stdbool.h>
> -#include <sys/queue.h>

#include <rte_bsd_queue.h> is required here since TAILQ_HEAD is used
below in the header.

>
> #include <rte_pci.h>
>