Re: [PATCH v3 11/44] lib: remove use of sys/queue.h

Andrew Rybchenko
2025-11-09T14:48:40Z

On 11/3/25 19:47, Stephen Hemminger wrote:
> Use the new rte_bsd_queue.h where needed but most files already
> get the needed macros from rte_tailq.h
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

[...]

> diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
> index 1021ede0c2..bf8e870151 100644
> --- a/lib/mempool/rte_mempool.c
> +++ b/lib/mempool/rte_mempool.c
> @@ -12,7 +12,6 @@
> #include <unistd.h>
> #include <inttypes.h>
> #include <errno.h>
> -#include <sys/queue.h>
>
> #include <eal_export.h>
> #include <rte_common.h>

I'm wondering why rte_bsd_queue.h is not added here instead of
sys/queue.h since the code definitely uses corresponding macros.
Is it OK to rely on indirect include via other headers?